-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split verify-gen into multiple targets in pre-push pre-commit hook #5374
Conversation
This addresses swap file increase issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5374 +/- ##
=======================================
Coverage 52.44% 52.44%
=======================================
Files 272 272
Lines 29349 29349
=======================================
Hits 15391 15391
Misses 13152 13152
Partials 806 806 ☔ View full report in Codecov by Sentry. |
entry: make go-test | ||
language: system | ||
stages: [pre-push] | ||
- repo: https://github.com/gitleaks/gitleaks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the extra indent here intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editor changes.. Unintentional. But doesn't harm ? I can remove the indentation if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, it was just a bit hard for me to visualize the diff, but doesn't have to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 51c6a806489e81dc8a7478ebc12de9144588888c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes ##5318
Special notes for your reviewer:
TODOs:
Release note: