Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] upgrade to CAPI 1.9.3 #5375

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Jan 17, 2025

What type of PR is this?

What this PR does / why we need it:

  • Testing with local copy of CAPI with additional logs
    Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
    Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nawazkh. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from marosset January 17, 2025 18:31
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 17, 2025
@nawazkh
Copy link
Member Author

nawazkh commented Jan 17, 2025

/test pull-cluster-api-provider-azure-capi-e2e

@nawazkh
Copy link
Member Author

nawazkh commented Jan 17, 2025

/test pull-cluster-api-provider-azure-capi-e2e

1 similar comment
@nawazkh
Copy link
Member Author

nawazkh commented Jan 17, 2025

/test pull-cluster-api-provider-azure-capi-e2e

@nawazkh
Copy link
Member Author

nawazkh commented Jan 17, 2025

/test pull-cluster-api-provider-azure-capi-e2e

@k8s-ci-robot
Copy link
Contributor

@nawazkh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-test 257017b link true /test pull-cluster-api-provider-azure-test
pull-cluster-api-provider-azure-apidiff 257017b link false /test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-capi-e2e 257017b link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-e2e-aks 257017b link true /test pull-cluster-api-provider-azure-e2e-aks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants