-
Notifications
You must be signed in to change notification settings - Fork 459
Add support for zone-redundant load balancers #5944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for zone-redundant load balancers #5944
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7572b39 to
67685f0
Compare
67685f0 to
2e5d373
Compare
2e5d373 to
e29bc2e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5944 +/- ##
==========================================
+ Coverage 44.54% 44.68% +0.13%
==========================================
Files 279 279
Lines 25140 25281 +141
==========================================
+ Hits 11199 11296 +97
- Misses 13128 13159 +31
- Partials 813 826 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bryan-cox can you add this new functionality to the existing E2E scenario for a private cluster, which ships with/ an internal LB? E.g.: $ git diff templates/flavors/private/patches/private-lb.yaml
diff --git a/templates/flavors/private/patches/private-lb.yaml b/templates/flavors/private/patches/private-lb.yaml
index 76e1539df..a2933e299 100644
--- a/templates/flavors/private/patches/private-lb.yaml
+++ b/templates/flavors/private/patches/private-lb.yaml
@@ -7,6 +7,10 @@ spec:
apiServerLB:
name: ${CLUSTER_NAME}-internal-lb
type: Internal
+ availabilityZones:
+ - "1"
+ - "2"
+ - "3"
nodeOutboundLB:
frontendIPsCount: 1
controlPlaneOutboundLB:After you apply the above changes to the template partial above, render updated templates w/ |
|
/test pull-cluster-api-provider-azure-e2e-optional |
e29bc2e to
3b77777
Compare
|
/test pull-cluster-api-provider-azure-e2e-optional |
|
/retest |
3b77777 to
6fa7de7
Compare
|
/test pull-cluster-api-provider-azure-e2e-optional |
36f5c8f to
e69a17e
Compare
|
Attempting to get the PR back to its stable state before attempting to address #5944 (comment) again. |
|
/test pull-cluster-api-provider-azure-e2e-optional |
461ebb0 to
9ca4c6c
Compare
|
/test pull-cluster-api-provider-azure-e2e-optional |
a37ab02 to
b5bbbad
Compare
|
/test pull-cluster-api-provider-azure-e2e-optional |
Add comprehensive documentation for zone-redundant load balancer feature: - Explain Azure zone redundancy concepts for load balancers - Provide configuration examples for all load balancer types: - Internal load balancers (API server) - Public load balancers - Node outbound load balancers - Control plane outbound load balancers - Include complete highly available cluster example - Document important considerations: - Immutability of zones after creation - Region support requirements - Standard SKU requirement - Backend pool placement best practices - Provide migration guidance for existing clusters - Add troubleshooting section - Document best practices
b5bbbad to
aee70a4
Compare
- Add AvailabilityZones field to LoadBalancerSpec API - Implement zone support in service layer for frontend IP configs - Add webhook validation for zone immutability - Update generated CRD manifests - Add zone redundancy to private cluster flavor
- Add unit tests for zone configuration on frontend IPs - Add E2E test for zone-redundant LB verification - Add apiserver-ilb-zones flavor for E2E testing
aee70a4 to
daacbf5
Compare
|
/test pull-cluster-api-provider-azure-e2e-optional |
|
@bryan-cox: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements support for configuring availability zones on Azure load balancers to enable zone-redundant configurations for high availability.
Azure load balancers can be configured as zone-redundant to ensure high availability across multiple availability zones within a region. This feature allows users to specify availability zones (1, 2, 3) on load balancers, which are then set on the frontend IP configurations.
Key changes:
AvailabilityZonesfield toLoadBalancerSpecAPIWhich issue(s) this PR fixes:
Fixes #5709
Special notes for your reviewer:
This implementation follows Azure's zone redundancy model:
The E2E test is optional and creates a cluster with zone-redundant load balancers to verify the feature works end-to-end in Azure.
TODOs:
Release note: