Upgrade capi

[vishesh92]

Issue #, if available:
Fixes #420
Description of changes:
Followed t he changes mentioned in the CAPI documentation and some changes other minor changes to make it compatible with latest version of CAPI.
https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.6-to-v1.7
https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.7-to-v1.8
https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.8-to-v1.9

Copilot generated summary

This pull request includes various updates and improvements across multiple files, focusing on configuration changes, dependency updates, and code refactoring. Below is a summary of the most important changes:

Configuration Updates

• .golangci.yml: Removed skip-dirs and added tests: false under run, and moved excluded directories to exclude-dirs under issues. [1] [2]

Dependency Updates

• Makefile: Updated the go mod tidy command to use compatibility version 1.22 instead of 1.21.

Code Refactoring

• Makefile: Simplified the generate-conversion command by removing --input-dirs and using --output-file directly.
• api/v1beta2/cloudstackmachine_types_test.go: Replaced pointer with ptr for utility functions. [1] [2] [3]

Documentation and Metadata Updates

• config/crd/bases/infrastructure.cluster.x-k8s.io_cloudstackaffinitygroups.yaml: Updated controller-gen.kubebuilder.io/version annotation and improved descriptions for better readability. [1] [2] [3] [4] [5] [6] [7]
• config/crd/bases/infrastructure.cluster.x-k8s.io_cloudstackclusters.yaml: Similar updates to annotations and descriptions as in the affinity groups file. [1] [2] [3] [4] [5]

These changes collectively enhance the configuration management, update dependencies to newer versions, and improve code readability and maintainability.

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vishesh92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name	Link
🔨 Latest commit	2dcac77
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/67deee1d762369000833c667
😎 Deploy Preview	https://deploy-preview-427--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 80.35714% with 22 lines in your changes missing coverage. Please review.

Project coverage is 25.80%. Comparing base (d597e80) to head (2dcac77).
Report is 80 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/cloud/instance.go	66.66%	13 Missing ⚠️
controllers/cloudstackmachine_controller.go	87.27%	5 Missing and 2 partials ⚠️
pkg/cloud/isolated_network.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   25.66%   25.80%   +0.13%     
==========================================
  Files          59       72      +13     
  Lines        5563     6720    +1157     
==========================================
+ Hits         1428     1734     +306     
- Misses       3996     4827     +831     
- Partials      139      159      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[k8s-ci-robot]

@vishesh92: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
capi-provider-cloudstack-presubmit-build	2dcac77	link	true	/test capi-provider-cloudstack-presubmit-build
capi-provider-cloudstack-presubmit-unit-test	2dcac77	link	true	/test capi-provider-cloudstack-presubmit-unit-test
capi-provider-cloudstack-presubmit-e2e-smoke-test	2dcac77	link	true	/test capi-provider-cloudstack-presubmit-e2e-smoke-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[blueorangutan]

Test Results : (tid-654)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.31.6
Kubernetes Version upgrade from: v1.30.10
Kubernetes Version upgrade to: v1.31.6
CloudStack Version: 4.20
Template: ubuntu-2404-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr427-sl-654.zip

Summarizing 6 Failures:
 [FAIL] When the specified resource does not exist [It] Should fail due to the specified zone is not found [TC3]
 /jenkins/workspace/capc-e2e-new/test/e2e/invalid_resource.go:253
 [FAIL] When the specified resource does not exist When starting with a healthy cluster [It] Should fail to upgrade control plane machine due to insufficient compute resources
 /jenkins/workspace/capc-e2e-new/test/e2e/invalid_resource.go:253
 [FAIL] When testing clusters in a VPC network [It] Should successfully create a cluster in a VPC network
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/cluster_helpers.go:147
 [FAIL] When testing affinity group [It] Should have host affinity group when affinity is pro
 /jenkins/workspace/capc-e2e-new/test/e2e/common.go:359
 [FAIL] When testing resource cleanup [AfterEach] Should create a new network when the specified network does not exist
 /jenkins/workspace/capc-e2e-new/test/e2e/resource_cleanup.go:101
 [FAIL] When testing node drain timeout [It] A node should be forcefully removed if it cannot be drained in time
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/deployment_helpers.go:542

Ran 31 of 32 Specs in 9593.971 seconds
FAIL! -- 25 Passed | 6 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (9593.97s)
FAIL