Add support for Instance Alias IP Ranges

[jwmay2012]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Allows instances to be created with a Secondary Alias IP/CIDR Range configured.
https://cloud.google.com/vpc/docs/alias-ip

This enables things like Cilium to use Google Cloud's networks for Native Routing.
By giving each pod/service an IP from the Alias IP Range.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Add support for Instance Alias IP Ranges. `GCPMachine.Spec.AliasIPRanges` This allows for [Native Routing](https://docs.cilium.io/en/stable/network/concepts/routing/#google-cloud).

[k8s-ci-robot]

Hi @jwmay2012. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	a25d801
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/67d0ae064ac4850007afc99b
😎 Deploy Preview	https://deploy-preview-1314--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[damdo]

/ok-to-test

[jwmay2012]

Rebased.
We're running this code and it's helping us enable Native Routing for our Pods in GCP.
Let me know if there's anything else to be done before merge :)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jwmay2012]

Having the ability to utilize Native Networking in GCP for pods and services from CAPI && CAPG is pretty neat and enabled by being able to configure these Alias IP Ranges.
We're still using this for our clusters but would love to get it upstreamed and stop using our custom build :)
A pretty standard GCPMachine spec addition and conversion to the existing GCP SDK structs.

Is there something I could do to help move this ticket forward? Thanks :)

[damdo]

Would you please explicitly mark these fields as required?
Do we need any other form of openAPI schema validation for these two fields?

Maybe something similar to this for example? (not verified) https://github.com/openshift/api/blob/9e59a77ed2e001a28bf82cc1084699a4989bba23/operator/v1/types_ingress.go#L452-L459

[jwmay2012]

Done :)
The SubnetworkRangeName field is optional and can be set automatically by GCP when empty, so no 'required' flag for that one.

ipCidrRange accepted values-- (IPv4) or (/netmask) or (IPv4/netmask)

Additional manual validation--

      aliasIPRanges:
      - ipCidrRange: /33
        subnetworkRangeName: subnet-name

API server says:
      GCPMachineTemplate.infrastructure.cluster.x-k8s.io "my-machine-template" is invalid: spec.template.spec.aliasIPRanges[0].ipCidrRange:
        Invalid value: "/33": spec.template.spec.aliasIPRanges[0].ipCidrRange in body should match '^((([0-9]|[0-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[0-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])/([0-9]|[12][0-9]|3[0-2])|(([0-9]|[0-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[0-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])|(/([0-9]|[12][0-9]|3[0-2])))$' (reason: Invalid)

------------------------------------------

      aliasIPRanges:
      - subnetworkRangeName: subnet-name

Invalid value: ""

------------------------------------------

      aliasIPRanges:
      - ipCidrRange: 1270.0.0.1/24
        subnetworkRangeName: subnet-name

 Invalid value: "1270.0.0.1/24"

------------------------------------------

      aliasIPRanges:
      - ipCidrRange: 1270.0.0.1/24
        subnetworkRangeName: subnet-name

 Invalid value: "127.0.0.1a"

------------------------------------------

no `aliasIPRanges:` field

API server accepts

------------------------------------------

      aliasIPRanges:
      - ipCidrRange: /24
        subnetworkRangeName: subnet-name

API server accepts

------------------------------------------

      aliasIPRanges:
      - ipCidrRange: 127.0.0.1/24
        subnetworkRangeName: subnet-name

API server accepts

------------------------------------------

      aliasIPRanges:
      - ipCidrRange: 127.0.0.1
        subnetworkRangeName: subnet-name

API server accepts

------------------------------------------

      aliasIPRanges:
      - ipCidrRange: /24

API server accepts

------------------------------------------

[damdo]

I think this would be a good addition.
Any thoughts @cpanato @salasberryfin @richardcase ?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jwmay2012
Once this PR has been reviewed and has the lgtm label, please assign dims for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jwmay2012]

/retest