Skip to content

chore: don't use Requeue in controller-runtime#1516

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
justinsb:dont_use_requeue_in_controller_runtime
Aug 31, 2025
Merged

chore: don't use Requeue in controller-runtime#1516
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
justinsb:dont_use_requeue_in_controller_runtime

Conversation

@justinsb

@justinsb justinsb commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

It is deprecated in newer versions of controller-runtime,
because it should not be used.


NONE

It is deprecated in newer versions of controller-runtime,
because it should not be used.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 29, 2025
@netlify

netlify Bot commented Aug 29, 2025

Copy link
Copy Markdown

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 2dcd7ab
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/68b1761d3c67530009b766e5
😎 Deploy Preview https://deploy-preview-1516--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2025
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cpanato and damdo August 29, 2025 09:42
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 29, 2025
@justinsb

Copy link
Copy Markdown
Contributor Author

We're going to need this to bump controller-runtime, but we might want to cherry-pick to 1.10 (and it makes #1509 smaller)

@salasberryfin

Copy link
Copy Markdown
Contributor

Thanks @justinsb

/lgtm

/cherrypick release-1.10

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

@salasberryfin: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

Details

In response to this:

Thanks @justinsb

/lgtm

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit a271350 into kubernetes-sigs:main Aug 31, 2025
21 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown

@salasberryfin: new pull request created: #1520

Details

In response to this:

Thanks @justinsb

/lgtm

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants