Skip to content

tests: test with kubernetes 1.33.2#1527

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
justinsb:kube_1_33_support
Sep 9, 2025
Merged

tests: test with kubernetes 1.33.2#1527
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
justinsb:kube_1_33_support

Conversation

@justinsb

@justinsb justinsb commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test with kubernetes 1.33, which is notable because it drops support for in-tree cloudprovider.


NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from cpanato and dims September 5, 2025 03:15
@k8s-ci-robot

k8s-ci-robot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2025
@netlify

netlify Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 53b662c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/68bc57339653bc0008cd1943
😎 Deploy Preview https://deploy-preview-1527--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@justinsb justinsb mentioned this pull request Sep 5, 2025
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2025
@justinsb

justinsb commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

OK so this fails without #1506 https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-gcp/1527/pull-cluster-api-provider-gcp-e2e-test/1963803065215619072.

I have now cherry-picked #1506 onto this branch because I believe it should pass (🤞 )

/hold as this PR is now doing multiple things!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2025
@justinsb

justinsb commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

OK so this is good news, this is now passing with #1526 merged in. I'll clean up #1526 and revert it from this branch, so we can see it fail then pass again!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 5, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 6, 2025
@salasberryfin

salasberryfin commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks!

/lgtm

Let's keep hold and give @cpanato @damdo some extra time for a second review.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2025
@damdo

damdo commented Sep 8, 2025

Copy link
Copy Markdown
Member

/test pull-cluster-api-provider-gcp-test

It got stuck

@damdo

damdo commented Sep 8, 2025

Copy link
Copy Markdown
Member

/test pull-cluster-api-provider-gcp-test

@damdo

damdo commented Sep 8, 2025

Copy link
Copy Markdown
Member

/test pull-cluster-api-provider-gcp-e2e-test

@salasberryfin

salasberryfin commented Sep 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks @damdo. All checks are passing now.

I think we're good to unhold this now.

/unhold

@damdo

damdo commented Sep 9, 2025

Copy link
Copy Markdown
Member

Indeed thanks for the heads up

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1cf9dd4 into kubernetes-sigs:main Sep 9, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato Awaiting requested review from cpanato
@dims dims Awaiting requested review from dims

Assignees

@salasberryfin salasberryfin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justinsb @k8s-ci-robot @salasberryfin @damdo