tests: add e2e test for MachinePool#1539
Open
justinsb wants to merge 5 commits into
Open
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
justinsb
force-pushed
the
machinepool_test
branch
2 times, most recently
from
ed3b28d to
3e3b5fd
Compare
k8s-ci-robot
removed
the
needs-rebase
justinsb
force-pushed
the
machinepool_test
branch
6 times, most recently
from
0196c4b to
8231d8c
Compare
Contributor
Author
|
WIP because this is adding the test to #1506 |
justinsb
force-pushed
the
machinepool_test
branch
from
8231d8c to
45925ca
Compare
k8s-ci-robot
added
release-note-none
justinsb
force-pushed
the
machinepool_test
branch
4 times, most recently
from
76c0a15 to
b5c5002
Compare
Co-authored-by: Christian Schlotter <christi.schlotter@gmail.com>
In order for nodes to be associated to the MachinePool, we need to populate the spec.providerIDList field. This field is known to the MachinePool controller. Co-authored-by: Christian Schlotter <christi.schlotter@gmail.com>
justinsb
force-pushed
the
machinepool_test
branch
from
b5c5002 to
4ed7a24
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
justinsb
changed the title
Member
|
@justinsb is this reviewable/mergeable? Or do you want to add other PRs before this one? TY |
k8s-ci-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
Hey @justinsb @bochengchu should we resume this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to MachinePool work #1506