Add verify-go-directive check from core CAPI#1549
Conversation
k8s-ci-robot
added
the
release-note-none
|
@damdo: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @justinsb @salasberryfin This is used in CAPI upstream and checks the go.mod directive is in concert with the desired one specified in the Makefile. |
|
cc. @chrischdi |
| verify-go-directive: | ||
| # use the core Cluster API script directly to verify the go directive matches the desired one. | ||
| # ref: https://github.com/kubernetes-sigs/cluster-api/blob/v1.10.7/hack/verify-go-directive.sh | ||
| curl --retry $(CURL_RETRIES) -fsL https://raw.githubusercontent.com/kubernetes-sigs/cluster-api/refs/tags/v1.11.0/hack/verify-go-directive.sh | bash -s -- -g $(GOLANG_DIRECTIVE_VERSION) |
There was a problem hiding this comment.
(I'd copy over that script instead of relying on curl, maybe could hit rate limits or flake due to other things, but up to you)
There was a problem hiding this comment.
I'd prefer not to maintain that also over here TBH
If we see issues with curl we might want to revisit :)
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/unhold CAPA maintainers were happy. I suppose this is ok here too. |
k8s-ci-robot
removed
the
do-not-merge/hold
5 participants
What type of PR is this?
/kind other
What this PR does / why we need it:
Same reason as: kubernetes-sigs/cluster-api#10258