Make GCPCluster network name and subnets immutable#1676
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bobu-putheeckal The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @bobu-putheeckal! |
|
Hi @bobu-putheeckal. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes #1576
This updates the GCPCluster validating webhook to reject updates to
spec.network.nameandspec.network.subnets. Changing those fields after infrastructure has been provisioned can leave existing machines on the old VPC/subnets while future reconciliation uses the new network configuration.The PR also adds webhook unit coverage for both immutable fields.
Tests:
go test ./webhooksKUBEBUILDER_ASSETS="/Users/agentzero/Library/Application Support/io.kubebuilder.envtest/k8s/1.34.0-darwin-arm64" go test ./api/... ./webhooks/...