Skip to content

Make GCPCluster network name and subnets immutable#1676

Open
bobu-putheeckal wants to merge 1 commit into
kubernetes-sigs:mainfrom
bobu-putheeckal:codex-capg-1576-immutable-network-fields
Open

Make GCPCluster network name and subnets immutable#1676
bobu-putheeckal wants to merge 1 commit into
kubernetes-sigs:mainfrom
bobu-putheeckal:codex-capg-1576-immutable-network-fields

Conversation

@bobu-putheeckal
Copy link
Copy Markdown

@bobu-putheeckal bobu-putheeckal commented May 24, 2026

Fixes #1576

This updates the GCPCluster validating webhook to reject updates to spec.network.name and spec.network.subnets. Changing those fields after infrastructure has been provisioned can leave existing machines on the old VPC/subnets while future reconciliation uses the new network configuration.

The PR also adds webhook unit coverage for both immutable fields.

Tests:

  • go test ./webhooks
  • KUBEBUILDER_ASSETS="/Users/agentzero/Library/Application Support/io.kubebuilder.envtest/k8s/1.34.0-darwin-arm64" go test ./api/... ./webhooks/...
GCPCluster `spec.network.name` and `spec.network.subnets` are now immutable.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 24, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 24, 2026

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit f400e23
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/6a1300f944c7af00085c7750
😎 Deploy Preview https://deploy-preview-1676--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot requested review from damdo and dims May 24, 2026 13:45
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bobu-putheeckal
Once this PR has been reviewed and has the lgtm label, please assign chrischdi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @bobu-putheeckal!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @bobu-putheeckal. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCPCluster network and subnet fields are mutable but updates result in broken/inconsistent state

2 participants