Adding GCPMachinePool Functionality #901

BrennenMM7 · 2023-04-18T20:14:15Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR Implements GCPMachinePool using Managed Instance Groups. This is needed to support the CAPI MachinePools object. Feature will allow cluster operators to deploy GCP MIG's to their CAPG clusters to take advantage of both Google Autoscaling of Compute Instances or utilizing cluster autoscaler to dynamically provision node resources.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #297,#1005

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

Feature: adds MachinePool/GCPMachinePool Objects to deploy Managed Instance Group services.

k8s-ci-robot · 2023-04-18T20:14:23Z

Welcome @BrennenMM7!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-04-18T20:14:24Z

Hi @BrennenMM7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-04-18T20:20:32Z

@BrennenMM7: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpanato

/ok-to-test
/assign @richardcase

thanks for your PR, an initial comments

cloud/services/compute/instancegroups/client.go

cloud/scope/machinepool.go

cloud/const.go

cloud/services/compute/instancegroups/doc.go

cloud/services/compute/instancegroups/instancegroups.go

exp/controllers/helpers.go

k8s-ci-robot · 2023-08-30T18:06:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BrennenMM7
Once this PR has been reviewed and has the lgtm label, please ask for approval from cpanato. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-triage-robot · 2024-01-21T08:17:56Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-20T08:31:16Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

cpanato · 2024-05-20T13:08:13Z

need rebase

BrennenMM7 · 2024-05-20T16:14:34Z

@damdo @cpanato PR has been rebased thanks 💯

k8s-ci-robot · 2024-05-20T16:18:12Z

@BrennenMM7: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-provider-gcp-verify	`3f4e888`	link	true	`/test pull-cluster-api-provider-gcp-verify`
pull-cluster-api-provider-gcp-test	`3f4e888`	link	true	`/test pull-cluster-api-provider-gcp-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot · 2024-05-30T23:14:41Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-triage-robot · 2024-06-30T00:10:30Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-06-30T00:10:34Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

damdo · 2024-06-30T09:31:42Z

/reopen

k8s-ci-robot · 2024-06-30T09:31:46Z

@damdo: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

damdo · 2024-06-30T09:31:53Z

/remove-lifecycle rotten

salasberryfin · 2024-07-02T06:54:02Z

Hey @BrennenMM7. We discussed previously the fact that we do not want to create a Kubeadm dependency, which was an issue with other providers too. I think we can do something similar to what CAPZ did here which decouples the MachinePool reconciler from Kubeadm. What do you think?

BrennenMM7 · 2024-07-08T16:58:21Z

@salasberryfin 👋 Yeah this looks good, I can easily port my changes to support this, I'll update and rebase this PR this week.

salasberryfin · 2024-09-24T15:31:22Z

Hey @BrennenMM7, would you be able to update this PR?

k8s-triage-robot · 2024-12-23T16:02:54Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

aslafy-z · 2024-12-24T01:48:02Z

/remove-lifecycle stale

salasberryfin · 2025-01-02T09:22:26Z

Thanks @aslafy-z. I think this is a relevant feature that should be supported by the provider but I see there's not much activity in this PR. @BrennenMM7, could you take a look at this?

BrennenMM7 · 2025-01-03T23:59:07Z

@salasberryfin 👋 Hey sorry for the inactive PR, I no longer have access to the same resources for CAPG development. I can pull forward my PR and try to add the previous items about agnostic bootstrap providers. However testing E2E would be under my own dime so best I can do is a test suite.

anmazzotti · 2025-02-06T14:58:41Z

For reference, this is a PR to abstract the same mechanism in CAPV: kubernetes-sigs/cluster-api-provider-azure#5416

justinsb · 2025-03-17T21:35:46Z

cloud/services/compute/instancegroupinstances/instancegroupinstances.go

+
+	if s.scope.GCPMachinePoolMachine.Status.ProvisioningState != v1beta1.Deleting {
+		log.Info("Deleting instance", "instance", s.scope.Name())
+		// Cordon and drain the node before deleting the instance.


Draining is nice, but my understanding is that e.g. CAPA doesn't do this. Would we be the first here?

Also, as this is at the kube level, shouldn't drain be done by the Machine controller (from an architectural standpoint)?

justinsb · 2025-03-17T21:38:24Z

exp/api/v1beta1/gcpmachinepoolmachine_types.go

+// +kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.ready",description="Machine ready status"
+
+// GCPMachinePoolMachine is the Schema for the GCPMachinePoolMachines API and represents a GCP Machine Pool.
+type GCPMachinePoolMachine struct {


Q: Should this just be a GCPMachine? e.g. a Pod in a StatefulSet is still a Pod.

justinsb · 2025-03-17T21:39:30Z

exp/controllers/gcpmachinepool_controller.go

+		).
+		// watch for changes in KubeadmConfig to sync bootstrap token
+		Watches(
+			&kubeadmv1.KubeadmConfig{},


I suggest this should not block an implementation under exp, it can always be added later (and that is what we are doing in other providers).

justinsb · 2025-03-17T23:40:55Z

Thanks for doing this @BrennenMM7 . I rebased and made a few very small tweaks and was able to get this working at head: main...justinsb:cluster-api-provider-gcp:tweak_gcp_machine_pool

I did have three suggestions/questions above (do we want to drain / should we use GCPMachine / do we need to block on kubeadm abstraction). But I propose that as this feature is experimental, we should merge and iterate. Maybe the GCPMachine vs GCPMachinePoolMachine is more blocking because it's a schema change...

In terms of landing this, I'm happy to create a PR with these commits as the start (keeping the author on them and more clearly marking things I had to change), or I can rebase and just make myself a Co-Author so that @BrennenMM7 gets the main credit (having done the bulk of the work here). I'll have to rebase anyway I believe so even in the first approach these commits will be changed a bit (I think).

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 18, 2023

k8s-ci-robot requested review from cpanato and dims April 18, 2023 20:14

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 18, 2023

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 18, 2023

cpanato requested changes Apr 18, 2023

View reviewed changes

k8s-ci-robot assigned richardcase Apr 18, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2023

k8s-ci-robot assigned cpanato Apr 18, 2023

BrennenMM7 force-pushed the GCPMachinePools branch from 7187b6d to 08edce3 Compare April 18, 2023 20:33

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023

BrennenMM7 force-pushed the GCPMachinePools branch from 08edce3 to dbffc56 Compare June 13, 2023 15:58

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023

BrennenMM7 requested a review from cpanato June 13, 2023 16:30

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2023

BrennenMM7 force-pushed the GCPMachinePools branch 2 times, most recently from 45b2b1a to caf5243 Compare August 30, 2023 17:54

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 30, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2024

Adding GCPMachinePool Functionality

4528f81

BrennenMM7 force-pushed the GCPMachinePools branch from 4cf6e2b to 4528f81 Compare May 20, 2024 16:12

go mod tidy after rebase

3f4e888

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2024

k8s-ci-robot closed this Jun 30, 2024

k8s-ci-robot reopened this Jun 30, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 30, 2024

salasberryfin mentioned this pull request Sep 6, 2024

Move managed cluster support (GKE) to general availability #1168

Open

2 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 23, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2024

justinsb reviewed Mar 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding GCPMachinePool Functionality #901

Adding GCPMachinePool Functionality #901

BrennenMM7 commented Apr 18, 2023 •

edited

Loading

k8s-ci-robot commented Apr 18, 2023

k8s-ci-robot commented Apr 18, 2023

k8s-ci-robot commented Apr 18, 2023

cpanato left a comment

k8s-ci-robot commented Aug 30, 2023

k8s-triage-robot commented Jan 21, 2024

k8s-triage-robot commented Feb 20, 2024

cpanato commented May 20, 2024

BrennenMM7 commented May 20, 2024

k8s-ci-robot commented May 20, 2024 •

edited

Loading

k8s-ci-robot commented May 30, 2024

k8s-triage-robot commented Jun 30, 2024

k8s-ci-robot commented Jun 30, 2024

damdo commented Jun 30, 2024

k8s-ci-robot commented Jun 30, 2024

damdo commented Jun 30, 2024

salasberryfin commented Jul 2, 2024

BrennenMM7 commented Jul 8, 2024

salasberryfin commented Sep 24, 2024

k8s-triage-robot commented Dec 23, 2024

aslafy-z commented Dec 24, 2024

salasberryfin commented Jan 2, 2025

BrennenMM7 commented Jan 3, 2025

anmazzotti commented Feb 6, 2025

justinsb Mar 17, 2025

justinsb Mar 17, 2025

justinsb Mar 17, 2025

justinsb commented Mar 17, 2025

Adding GCPMachinePool Functionality #901

Are you sure you want to change the base?

Adding GCPMachinePool Functionality #901

Conversation

BrennenMM7 commented Apr 18, 2023 • edited Loading

k8s-ci-robot commented Apr 18, 2023

k8s-ci-robot commented Apr 18, 2023

k8s-ci-robot commented Apr 18, 2023

cpanato left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 30, 2023

k8s-triage-robot commented Jan 21, 2024

k8s-triage-robot commented Feb 20, 2024

cpanato commented May 20, 2024

BrennenMM7 commented May 20, 2024

k8s-ci-robot commented May 20, 2024 • edited Loading

k8s-ci-robot commented May 30, 2024

k8s-triage-robot commented Jun 30, 2024

k8s-ci-robot commented Jun 30, 2024

damdo commented Jun 30, 2024

k8s-ci-robot commented Jun 30, 2024

damdo commented Jun 30, 2024

salasberryfin commented Jul 2, 2024

BrennenMM7 commented Jul 8, 2024

salasberryfin commented Sep 24, 2024

k8s-triage-robot commented Dec 23, 2024

aslafy-z commented Dec 24, 2024

salasberryfin commented Jan 2, 2025

BrennenMM7 commented Jan 3, 2025

anmazzotti commented Feb 6, 2025

justinsb Mar 17, 2025

Choose a reason for hiding this comment

justinsb Mar 17, 2025

Choose a reason for hiding this comment

justinsb Mar 17, 2025

Choose a reason for hiding this comment

justinsb commented Mar 17, 2025

BrennenMM7 commented Apr 18, 2023 •

edited

Loading

k8s-ci-robot commented May 20, 2024 •

edited

Loading