✨ Promote CAPI v1beta2 conditions in CAPIBM v1beta3 api's#2623
Open
Karthik-K-N wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
✨ Promote CAPI v1beta2 conditions in CAPIBM v1beta3 api's#2623Karthik-K-N wants to merge 1 commit intokubernetes-sigs:mainfrom
Karthik-K-N wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
area/provider/ibmcloud
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Karthik-K-N The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
/hold |
k8s-ci-robot
added
size/XXL
Contributor
Author
|
Tested by creating a normal PowerVS cluster |
Contributor
Author
|
Suspecting a bug upstream and created a PR kubernetes-sigs/cluster-api#13336, Lets wait to hear back from the maintainer, This PR is blocked till then |
Contributor
Author
|
With Infra creation flow |
Karthik-K-N
force-pushed
the
promote-v1beta3-condition
branch
from
2e86ad0 to
5846f09
Compare
Karthik-K-N
force-pushed
the
promote-v1beta3-condition
branch
from
5846f09 to
96e2dc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR promots conditions for IBMPowerVSCluster, IBMPowerVSMachine and IBMPowerVSImage resources, Following changes are done
Necessary conversion functions are added and udpated fuzz tests to make sure no data is lost during conversions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # Part of #2401
Special notes for your reviewer:
In CAPI the apiversion is v1beta2 but for CAPIBM its v1beta3, so we are using some CAPI's helper functions to convert the status, there the function name looks like v1beta1 to v1beta2 and vice versa, We are not supposed to get confused with that.
/area provider/ibmcloud
Release note: