Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update capd template to use 1.6 best practices #105

Merged
merged 3 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hack/tests/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ KUBE_RBAC_PROXY_VERSION ?= v0.5.0
KUBE_RBAC_IMAGE_REPOSITORY ?= quay.io/coreos
KUBE_RBAC_PROXY ?= kube-rbac-proxy
DEV_REGISTRY ?= localhost:5000
CAPI_VERSION := v1.5.99
CAPI_VERSION := v1.6.99
XDG_CONFIG_HOME ?= $(HOME)/.config

.start-kind-cluster:
@kind delete cluster; sleep 20; docker network create kind; $(TEST_DIR)/utils/kind-with-registry.sh
Expand Down
14 changes: 5 additions & 9 deletions hack/tests/resources/docker-control-plane.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,25 +53,21 @@ spec:
certSANs:
- localhost
- 127.0.0.1
- 0.0.0.0
- host.docker.internal
controllerManager:
extraArgs:
enable-hostpath-provisioner: "true"
initConfiguration:
nodeRegistration:
criSocket: /var/run/containerd/containerd.sock
kubeletExtraArgs:
eviction-hard: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
nodeRegistration: {}
joinConfiguration:
nodeRegistration:
criSocket: /var/run/containerd/containerd.sock
kubeletExtraArgs:
eviction-hard: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
nodeRegistration: {}
machineTemplate:
infrastructureRef:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: DockerMachineTemplate
name: km-cp-control-plane
namespace: default
replicas: 1
version: v1.28.0
version: v1.28.7

Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha4
kind: KubemarkMachineTemplate
name: km-wl-kubemark-external-md-0
version: 1.28.0
version: 1.28.7
---
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha4
kind: KubemarkMachineTemplate
Expand Down
2 changes: 1 addition & 1 deletion hack/tests/resources/kubemark-machine-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha4
kind: KubemarkMachineTemplate
name: km-wl-kubemark-md-0
version: 1.28.0
version: 1.28.7
---
apiVersion: infrastructure.cluster.x-k8s.io/v1alpha4
kind: KubemarkMachineTemplate
Expand Down
13 changes: 4 additions & 9 deletions templates/cluster-template-capd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,12 @@ spec:
controllerManager:
extraArgs: {enable-hostpath-provisioner: 'true'}
apiServer:
certSANs: [localhost, 127.0.0.1]
# host.docker.internal is required by kubetest when running on MacOS because of the way ports are proxied.
certSANs: [localhost, 127.0.0.1, 0.0.0.0, host.docker.internal]
initConfiguration:
nodeRegistration:
criSocket: unix:///var/run/containerd/containerd.sock
kubeletExtraArgs:
eviction-hard: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
nodeRegistration: {} # node registration parameters are automatically injected by CAPD according to the kindest/node image in use.
joinConfiguration:
nodeRegistration:
criSocket: unix:///var/run/containerd/containerd.sock
kubeletExtraArgs:
eviction-hard: nodefs.available<0%,nodefs.inodesFree<0%,imagefs.available<0%
nodeRegistration: {} # node registration parameters are automatically injected by CAPD according to the kindest/node image in use.
version: "${KUBERNETES_VERSION}"
---
apiVersion: cluster.x-k8s.io/v1beta1
Expand Down
Loading