Skip to content

Conversation

@lentzi90
Copy link
Contributor

What this PR does / why we need it:

Golanci-lint is updated to the newest version.

Two new linting errors appeared:

  1. The errors package conflicts with standard library package.
  2. The shared package name is considered "meaningless".

I have renamed these packages to capoerrors and e2eshared.

This is a backport of #2894.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign emilienm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2025
@netlify
Copy link

netlify bot commented Dec 11, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit fb87e61
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/693aa9236ed5090008ac49d9
😎 Deploy Preview https://deploy-preview-2902--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Golanci-lint is updated to the newest version.

Two new linting errors appeared:
1. The errors package conflicts with standard library package.
2. The shared package name is considered "meaningless".

I have renamed these packages to capoerrors and e2eshared.

This is a backport of kubernetes-sigs#2894.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/backport-golangci-lint-bump-release-0.13 branch from 9463eec to fb87e61 Compare December 11, 2025 11:21
@lentzi90
Copy link
Contributor Author

/hold
I am not sure we should really do this for release branches.
The golangci-lint updated workflow should not even run against PRs. Fixed for release-0.13 in #2904

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2025
@smoshiur1237
Copy link
Contributor

I don't see any harm to have at least in release 0.13. So lgtm from my side
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

3 participants