-
Notifications
You must be signed in to change notification settings - Fork 283
🌱 Bump golanci-lint to v2.7.2 #2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-0.13
Are you sure you want to change the base?
🌱 Bump golanci-lint to v2.7.2 #2902
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Golanci-lint is updated to the newest version. Two new linting errors appeared: 1. The errors package conflicts with standard library package. 2. The shared package name is considered "meaningless". I have renamed these packages to capoerrors and e2eshared. This is a backport of kubernetes-sigs#2894. Signed-off-by: Lennart Jern <[email protected]>
9463eec to
fb87e61
Compare
|
/hold |
|
I don't see any harm to have at least in release 0.13. So lgtm from my side |
What this PR does / why we need it:
Golanci-lint is updated to the newest version.
Two new linting errors appeared:
I have renamed these packages to capoerrors and e2eshared.
This is a backport of #2894.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: