Skip to content

✨ Allow to set NestedHV, FtEncryptionMode and MigrateEncryption#3740

Open
sathieu wants to merge 1 commit intokubernetes-sigs:mainfrom
sathieu:NestedHVEnabled-FtEncryptionMode-MigrateEncryption
Open

✨ Allow to set NestedHV, FtEncryptionMode and MigrateEncryption#3740
sathieu wants to merge 1 commit intokubernetes-sigs:mainfrom
sathieu:NestedHVEnabled-FtEncryptionMode-MigrateEncryption

Conversation

@sathieu
Copy link

@sathieu sathieu commented Dec 23, 2025

What this PR does / why we need it:

respectively:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3713

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2025
@k8s-ci-robot k8s-ci-robot requested review from laozc and srm09 December 23, 2025 20:15
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 23, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sathieu. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 23, 2025
@sathieu
Copy link
Author

sathieu commented Dec 29, 2025

Can someone add ok-to-test?

Cc @sbueringer

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 30, 2025
@sbueringer
Copy link
Member

/ok-to-test

fyi, we'll start working on v1beta2 (this change has to be rebased eventually to be added only to v1beta2)

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2026
@sathieu sathieu force-pushed the NestedHVEnabled-FtEncryptionMode-MigrateEncryption branch from cc227c7 to c6b7cce Compare January 2, 2026 17:25
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2026
respectively:

- nested hardware-assisted virtualization
- encrypted fault tolerance mode
- encrypted vMotion mode

Signed-off-by: Mathieu Parent <math.parent@etik.com>
@sathieu sathieu force-pushed the NestedHVEnabled-FtEncryptionMode-MigrateEncryption branch from c6b7cce to e386b66 Compare January 3, 2026 13:35
@sathieu sathieu changed the title ✨ Allow to set NestedHVEnabled, FtEncryptionMode and MigrateEncryption ✨ Allow to set NestedHV, FtEncryptionMode and MigrateEncryption Jan 3, 2026
@sathieu sathieu marked this pull request as ready for review January 3, 2026 15:25
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2026
@sathieu
Copy link
Author

sathieu commented Jan 3, 2026

/retest

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2026
@sbueringer
Copy link
Member

sbueringer commented Jan 28, 2026

We're now done with v1beta2. Can you please rebase this PR to add these fields to v1beta2?

Up to you if you want to add the fields only to v1beta2 and implement the necessary conversion or to add it to both v1beta1 and v1beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to enable Hardware virtualization (Expose hardware assisted virtualization to the guest OS)

3 participants