-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 metrics: use v1beta2 for condition metrics and add metrics for dockercluster devcluster dockermachine devmachine extensionconfig ipaddressclaim and crs #12006
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I wonder if we should just only emit v1beta2 conditions without a v1beta2 string in the metric name. This gives us future proof metrics from now onwards (we also know that v1beta1 conditions are not exactly perfect) |
7d7a337
to
1fc6261
Compare
In general seems fine. Obviously did not review the diff of the metrics config. I'll do that eventually on 9347. Did you check that our Grafana dashboards still work? (specifically the ones using conditions) |
…ckercluster devcluster dockermachine devmachine extensionconfig ipaddressclaim and crs
943aea4
to
1006ebf
Compare
checked and adjusted dashboards a bit. Hope I catched all cases. |
What this PR does / why we need it:
Changes all condition metrics to expose metrics from v1beta2 structs.
Adds new metrics for (only condition metrics for v1beta2):
Generated via #9347
/area devtools
Generated via:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #