🐛 Fix MaxLength of worker topology Name fields #12072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to existing webhook validation, the max length was effectively 63 characters. This updates the annotation (and CRD) to reflect this actual max length.
k8s-ci-robot
added
do-not-merge/needs-area
k8s-ci-robot
added
the
size/XS
JoelSpeed
reviewed
Apr 8, 2025
Adjust to 63 because maxLength is inclusive
|
/lgtm Please backport the v1beta1 change into release-1.10 |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 51efa780194f53e1dffd9f1646be4f1eeb365858
|
k8s-ci-robot
added
the
approved
sbueringer
added
tide/merge-method-squash
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Due to existing webhook validation, the effective max length was, and continues to be 63 characters. This updates the annotation (and CRD) to reflect this.
This PR came from a conversation in another PR: #12069 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area clusterclass
/area api