Skip to content

🌱 Add nomaps API linter #12083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Apr 9, 2025

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #11967

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from richardcase April 9, 2025 14:06
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from vincepri April 9, 2025 14:06
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 9, 2025
@sbueringer sbueringer added the area/ci Issues or PRs related to ci label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Apr 9, 2025
@sbueringer sbueringer changed the title Add nomaps API linter 🌱 Add nomaps API linter Apr 9, 2025
@sbueringer
Copy link
Member Author

/assign @JoelSpeed @fabriziopandini @chrischdi

@sivchari
Copy link
Member

sivchari commented Apr 9, 2025

Please update checksum of KAL.

version: v0.0.0-20250305092907-abd233a9fed8

Signed-off-by: Stefan Büringer [email protected]
@sbueringer sbueringer force-pushed the pr-add-nomaps-linter branch from 795b679 to c382a60 Compare April 9, 2025 14:30
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrischdi. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

Please update checksum of KAL.

version: v0.0.0-20250305092907-abd233a9fed8

Ups, thx

@sbueringer
Copy link
Member Author

sbueringer commented Apr 9, 2025

Okay. I'll defer this until I'm back from PTO early May :) (the findings need some discussion)

It looked locally like no findings, but I think that was just because I forgot to bump KAL or ran the wrong target.

@sbueringer sbueringer mentioned this pull request Apr 9, 2025
72 tasks
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants