Conversation
Signed-off-by: nayuta-ai <nayuta723@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @nayuta723. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| m, | ||
| corev1.EventTypeNormal, | ||
| EventRemediationTriggered, | ||
| "Triggered remediation for unhealthy Machine %s", |
There was a problem hiding this comment.
Remediation is not triggered by MHC, MHC only marks the machine as unhealthy (as well as it unmarks it in case it goes back to healthy).
Also, I would not add the name of the machine to an event added to the machine itself, it is redundant. May be, let's consider instead to track which MHC instance applied the event
There was a problem hiding this comment.
as well as it unmarks it in case it goes back to healthy
Should I handle this as well?
Signed-off-by: nayuta-ai <nayuta723@gmail.com>
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What this PR does / why we need it:
#11944 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #11944
/area machinehealthcheck