✨ topology: implement support for taints#13192
✨ topology: implement support for taints#13192chrischdi wants to merge 8 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
chrischdi
force-pushed
the
pr-taints-topology
branch
from
28a666f to
2a35617
Compare
k8s-ci-robot
added
size/XL
chrischdi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test help |
|
/test pull-cluster-api-e2e-main-gke |
internal/util/taints/validation.go
Outdated
| allErrs = append(allErrs, field.Invalid(idxPath.Child("key"), taint.Key, "taint is deprecated since 1.24 and should not be used anymore")) | ||
| } | ||
|
|
||
| if validation.IsQualifiedName(taint.Key) != nil { |
There was a problem hiding this comment.
Let's use content.IsLabelKey which is not deprecated :)
I am not sure if this is the right way to handle the response from this func. See how ValidateLabelName is implemented: https://github.com/kubernetes/kubernetes/blob/b4947a5891ab3faa822e8bfe0c17725b2ba18766/pkg/apis/core/validation/validation.go#L7131
(I think I don't want to use WithOrigin, but we should probably loop over the results and use the returned error string instead of writing our own)
| WaitForMachinePools: input.E2EConfig.GetIntervals(specName, "wait-machine-pool-nodes"), | ||
| }) | ||
|
|
||
| additionalControlPlaneNodeTaint := corev1.Taint{ |
There was a problem hiding this comment.
I'll skip reviewing this file for the moment until the e2e tests are green
There was a problem hiding this comment.
I missed some deepcopy regen, let's see if this fixes it.
…dget factor for cluster and clusterclass
chrischdi
force-pushed
the
pr-taints-topology
branch
from
d38664d to
3cb3c6b
Compare
|
/test pull-cluster-api-e2e-main-gke |
|
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
What this PR does / why we need it:
Implements support for taint propagation for the topology based clusters.
Based on top of: #13181
(so that one has to merge first)
Part of: #12908
Implement Cluster related API changes
Implement ClusterClass related API changes
Implement topology controller changes / field propagation
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area clusterclass