Skip to content

🐛 Clean up namespace in e2e tests#13233

Open
arshadd-b wants to merge 4 commits intokubernetes-sigs:mainfrom
arshadd-b:cleanup-ns
Open

🐛 Clean up namespace in e2e tests#13233
arshadd-b wants to merge 4 commits intokubernetes-sigs:mainfrom
arshadd-b:cleanup-ns

Conversation

@arshadd-b
Copy link
Contributor

@arshadd-b arshadd-b commented Jan 14, 2026

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #13019

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2026
@arshadd-b
Copy link
Contributor Author

arshadd-b commented Jan 14, 2026

Hi @sbueringer
I had checked the other tests I see mostly all the places clean up is happening either specifying manually deletion resources
or calling this cleanup function DumpSpecResourcesAndCleanup
But in scale.go deleteNamespace was missing, so added it
Please let me know anything I have missed
Thanks

@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Jan 14, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jan 14, 2026
mboersma
mboersma approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 16, 2026

LGTM label has been added.

DetailsGit tree hash: bec957f8bc48c4be497007f091b1499f4c7e64bd

fabriziopandini
fabriziopandini reviewed Feb 8, 2026
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arshadd-b thanks for jumping on this issue!

@sbueringer
Copy link
Member

sbueringer commented Feb 9, 2026

/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2026
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2026
sbueringer
sbueringer reviewed Feb 11, 2026
View reviewed changes
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 17, 2026
sbueringer
sbueringer reviewed Feb 17, 2026
View reviewed changes
@sbueringer
Copy link
Member

sbueringer commented Feb 17, 2026

/test pull-cluster-api-e2e-main-gke

@sbueringer
Copy link
Member

sbueringer commented Feb 17, 2026

Thank you very much!!

/lgtm
/approve

/test pull-cluster-api-e2e-main-gke

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 17, 2026

LGTM label has been added.

DetailsGit tree hash: ac8827335980484ae2b5ea14c6a4d7f4f446dee3

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

@richardcase richardcase Awaiting requested review from richardcase

@mboersma mboersma Awaiting requested review from mboersma

Assignees

@mboersma mboersma

@sbueringer sbueringer

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

scale e2e test is not cleaning up test namespaces after test

5 participants

@arshadd-b @k8s-ci-robot @sbueringer @mboersma @fabriziopandini