✨ Draft: Add ApplyConfiguration support for Cluster API types#13243
✨ Draft: Add ApplyConfiguration support for Cluster API types#13243VijetaPriya47 wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
Changes: - Add +genclient tags to all root API types in core/v1beta2, addons/v1beta2, bootstrap/kubeadm/v1beta2, and controlplane/kubeadm/v1beta2 - Add client-gen and applyconfiguration-gen v0.35.0 to build toolchain - Create Makefile targets for generating ApplyConfigurations and typed client - Generate type-safe ApplyConfiguration builders in pkg/generated/applyconfiguration/ - Generate typed clientset with Apply methods in pkg/generated/client/ - Add comprehensive documentation with usage examples - Add unit tests for generated ApplyConfiguration types Generated code is placed in pkg/generated/ following Kubernetes conventions to keep api/ directory clean and avoid circular imports.
Add the new ApplyConfigurations documentation to the book's table of contents under the Developer Guide section.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @VijetaPriya47. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Could you split this one into some PRs ? It's easy to read and review it, in addition, merging some PRs is easier than doing at once. |
|
I think 99% of this PR is generated code. I'm not sure if I see the benefit of trying to split that up. Independent of that, let's please use controller-gen to generate the ApplyConfigurations instead of introducing additional tools Why do we need the generated clientsets? |
Changes:
I added the generated code in pkg/generated. I saw the generated files being tracked in /api , so included it, if you say I could remove it too.
Generated code is placed in pkg/generated/ following Kubernetes conventions to keep api/ directory clean and avoid circular imports.
Fixes #12154
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #