🐛machinepool: Conditionally delegate taint removal - #14053
Open
rexagod wants to merge 1 commit into
Open
Conversation
Delegate uninitialized taint removal to the Machine controller when Machines do exist. Unlike earlier, both MachinePool and Machine controllers raced to drop the taint, which was unpredictable and could potentially cause problems with inequality-based selectors (see [1] for more). [1]:kubernetes-sigs#8258 (comment)
kubernetes-prow
Bot
added
the
area/machinepool
kubernetes-prow
Bot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
rexagod
changed the title
rexagod
changed the title
Member
|
/assign @richardcase @mboersma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Delegate uninitialized taint removal to the Machine controller when Machines do exist. Unlike earlier, both MachinePool and Machine controllers raced to drop the taint, which was unpredictable and could potentially cause problems with inequality-based selectors (see 1 for more), for instance.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #8258
/area machinepool