Skip to content

🌱 Promote PriorityQueue and ReconcilerRateLimiting feature gates to GA #14079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbueringer wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −4
Open

🌱 Promote PriorityQueue and ReconcilerRateLimiting feature gates to GA #14079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,11 @@ linters:
- staticcheck
text: 'SA1019: (env|mgr).GetEventRecorderFor is deprecated'

# TODO: Excludes that can be removed as part of the Cluster API v1.17 release.
- linters:
- staticcheck
text: 'SA1019: feature.(PriorityQueue|ReconcilerRateLimiting) is deprecated'

# TODO: Excludes for v1beta1, can be removed once v1beta1 has been removed (current plan: Cluster API v1.19).
- linters:
- staticcheck
Expand Down
4 changes: 2 additions & 2 deletions docs/book/src/developer/providers/migrations/v1.14-to-v1.15.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ maintainers of providers and consumers of our Go API.
Any feedback or contributions to improve following documentation is welcome!

<!-- TOC -->
* [Cluster API v1.13 compared to v1.14](#cluster-api-v113-compared-to-v114)
* [Cluster API v1.14 compared to v1.15](#cluster-api-v114-compared-to-v115)
* [Go version](#go-version)
* [Dependencies](#dependencies)
* [Graduation](#graduation)
Expand Down Expand Up @@ -39,7 +39,7 @@ Any feedback or contributions to improve following documentation is welcome!

## Graduation

-
- Both the `PriorityQueue` and the `ReconcilerRateLimiting` feature gate graduated to GA

## Implemented proposal

Expand Down
10 changes: 8 additions & 2 deletions feature/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ const (
//
// alpha: v1.10
// beta: v1.13
// GA: v1.15
//
// Deprecated: PriorityQueue feature is now GA and the corresponding feature flag will be removed in the v1.17 release.
PriorityQueue featuregate.Feature = "PriorityQueue"

// ReconcilerRateLimiting is a feature gate that controls if reconcilers are rate-limited.
Expand All @@ -79,6 +82,9 @@ const (
//
// alpha: v1.12
// beta: v1.13
// GA: v1.15
//
// Deprecated: ReconcilerRateLimiting feature is now GA and the corresponding feature flag will be removed in the v1.17 release.
ReconcilerRateLimiting featuregate.Feature = "ReconcilerRateLimiting"

// InPlaceUpdates is a feature gate for the in-place machine updates functionality.
Expand All @@ -100,10 +106,10 @@ func init() {
var defaultClusterAPIFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
// Every feature should be initiated here:
MachineWaitForVolumeDetachConsiderVolumeAttachments: {Default: true, PreRelease: featuregate.GA},
PriorityQueue: {Default: true, PreRelease: featuregate.GA},
ReconcilerRateLimiting: {Default: true, PreRelease: featuregate.GA},
MachinePool: {Default: true, PreRelease: featuregate.Beta},
MachineSetPreflightChecks: {Default: true, PreRelease: featuregate.Beta},
PriorityQueue: {Default: true, PreRelease: featuregate.Beta},
ReconcilerRateLimiting: {Default: true, PreRelease: featuregate.Beta},
ClusterTopology: {Default: false, PreRelease: featuregate.Alpha},
KubeadmBootstrapFormatIgnition: {Default: false, PreRelease: featuregate.Alpha},
RuntimeSDK: {Default: false, PreRelease: featuregate.Alpha},
Expand Down
Loading