Skip to content

🌱 Avoid unnecessary memory allocation in ssa.Patch after cache hit - #14085

Open
sbueringer wants to merge 2 commits into
kubernetes-sigs:mainfrom
sbueringer:pr-ssa-patch-memory
Open

🌱 Avoid unnecessary memory allocation in ssa.Patch after cache hit#14085
sbueringer wants to merge 2 commits into
kubernetes-sigs:mainfrom
sbueringer:pr-ssa-patch-memory

Conversation

@sbueringer

@sbueringer sbueringer commented Aug 14, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:
Around 4-5% of our memory allocation in core CAPI at stable state is just updating modified after a cache hit in ssa.Patch. We don't need that as we never read the updatedObject after ssa.Patch

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #13305

@kubernetes-prow kubernetes-prow Bot added do-not-merge/needs-area PR is missing an area label size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from elmiko and g-gaston August 14, 2026 09:30
@sbueringer sbueringer added area/provider/control-plane-kubeadm Issues or PRs related to KCP area/machineset Issues or PRs related to machinesets labels Aug 14, 2026
@kubernetes-prow kubernetes-prow Bot removed do-not-merge/needs-area PR is missing an area label labels Aug 14, 2026
@sbueringer sbueringer mentioned this pull request Aug 14, 2026
37 tasks
@kubernetes-prow

Copy link
Copy Markdown
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main ea5f0ae link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer

Copy link
Copy Markdown
Member Author

/hold

until #13803 is merged

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/machineset Issues or PRs related to machinesets area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant