Skip to content

馃悰 Convert CAPI resources in generic Lists - #14090

Open
immanuwell wants to merge 1 commit into
kubernetes-sigs:mainfrom
immanuwell:fix-clusterctl-convert-generic-list
Open

馃悰 Convert CAPI resources in generic Lists#14090
immanuwell wants to merge 1 commit into
kubernetes-sigs:mainfrom
immanuwell:fix-clusterctl-convert-generic-list

Conversation

@immanuwell

@immanuwell immanuwell commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

clusterctl convert treated a generic v1/List as one non CAPI object. CAPI resources under items stayed on v1beta1

This sends List items through the existing converter and keeps the List wrapper and metadata

Repro:

kubectl get clusters,machines -A -o yaml | clusterctl convert

Before this reports Converted 0 resource(s). Now nested resources are converted and counted

Which issue(s) this PR fixes:

None. Related to #12716.

/area clusterctl

@kubernetes-prow kubernetes-prow Bot added the area/clusterctl Issues or PRs related to clusterctl label Aug 15, 2026
@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @immanuwell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@immanuwell
immanuwell force-pushed the fix-clusterctl-convert-generic-list branch from 45bf5ba to 0bb3ea4 Compare August 15, 2026 06:13
@kubernetes-prow kubernetes-prow Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant