🐛 Fix panic when using embedded type aliases #1089
🐛 Fix panic when using embedded type aliases #1089tsaarni wants to merge 2 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tsaarni The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @tsaarni. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This PR is not needed anymore since issue was fixed by #1122 |
This pull request is NOT to be merged!
Controller-gen panics when parsing an embedded/inline struct that uses a type alias. This PR includes a test to reproduce the problem, however the panic only happens when type aliases are enabled so the test needs to be run like this in order to trigger panic
PR also includes a workaround for the panic that I found while troubleshooting the issue. It avoids panic but it isn’t the correct solution. As of now, I don't know how to do it properly, so I'm marking this PR as a Draft.
Fixes #1088