🌱 Allow string validation on XIntOrString

[cbandy]

This allows maxLength and MinLength on x-kubernetes-int-or-string fields. The former helps limit CEL validation costs.

[k8s-ci-robot]

Welcome @cbandy!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @cbandy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

This seems reasonable, thanks!

One question, if I were to use this feature, and provide a value that is a long integer, does the length of my integer, say 12 characters, also get validated with the same maximum length constraints? I assume the answer is yes but I'm not sure I see how the tests might demonstrate that this works

[cbandy]

One question, if I were to use this feature, and provide a value that is a long integer, does the length of my integer, say 12 characters, also get validated with the same maximum length constraints? I assume the answer is yes but I'm not sure I see how the tests might demonstrate that this works

In my testing with 1.31 and 1.32, the answer is no, pattern and maxLength do not affect integer values.

Go markers affect the YAML this project generates, and the Kubernetes API interprets that.

[sbueringer]

Thx!

/ok-to-test
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cbandy, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 951924f376de7af297d3b8ddf8887ee5bc05212b

[cbandy]

The former helps limit CEL validation costs.

😅 Except that it didn't until kubernetes/kubernetes#132837