-
Notifications
You must be signed in to change notification settings - Fork 483
docs(crictl): add detailed explanations for ps command output columns #1969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lucming The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @lucming! |
docs/crictl.md
Outdated
| # NAME: name of the container | ||
| # ATTEMPT: container restart count | ||
| # POD ID: sandbox container ID of the pod | ||
| # POD: name of the pod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes it more confusing. If you refer to sandbox in POD ID, refer to sandbox here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here, POD just means pod name in k8s, there is absolutely no connection to the sandbox.
b0e9715 to
a8e1250
Compare
|
@lucming please rebase to fixup the CI. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
#1964
Special notes for your reviewer:
Does this PR introduce a user-facing change?