Retry device enumeration on startup to prevent empty ResourceSlices#1009
Open
kasia-kujawa wants to merge 1 commit intokubernetes-sigs:mainfrom
Open
Retry device enumeration on startup to prevent empty ResourceSlices#1009kasia-kujawa wants to merge 1 commit intokubernetes-sigs:mainfrom
kasia-kujawa wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: Katarzyna Kujawa <katarzyna@cast.ai>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kasia-kujawa The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1008
Added a retry loop in
NewDeviceState().If the first enumeration returns 0 devices, the plugin retries every 5 seconds for up to 5 minutes before proceeding.
Errors still propagate immediately without retry.
Before the fix, no log was emitted after
Traverse GPU devicesand the emptyResourceSlicewas published silently.With the fix (
nvidiaDriverRoot: /home/kubernetes/bin/nvidia/, GKE COS, Tesla T4):Full logs with the fix from
nvidia-dra-driver-gpu-kubelet-pluginwhen GPU initialization needed slightly more time:https://gist.github.com/kasia-kujawa/1082b48357a0ae80d663f12ee665e34c