Skip to content

[WIP] Fix metrics test: nvidia_dra_requests_total may not exist before first use #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dims wants to merge 1 commit into from
+6 −1
Closed

[WIP] Fix metrics test: nvidia_dra_requests_total may not exist before first use #1028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/bats/test_gpu_robustness.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ bats::on_failure() {
run kubectl exec -n dra-driver-nvidia-gpu "${plugin_pod}" -c gpus -- \
sh -c 'curl -sf http://localhost:8080/metrics 2>/dev/null || wget -qO- http://localhost:8080/metrics'
assert_output --partial "nvidia_dra_prepared_devices"
assert_output --partial "nvidia_dra_requests_total"
Copy link
Copy Markdown
Contributor

@shivamerla shivamerla Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dims we register all metric at once here, so they should be reported with 0 value. Wondering why the test failed only for this metric.

Copy link
Copy Markdown
Member Author

@dims dims Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamerla i'd rather land this one which is complete fix #1029

rather than the mitigation in this PR.

# nvidia_dra_requests_total is a counter that only appears after the first
# DRA request. At setup_file time no pods have used a GPU yet, so the metric
# may not be registered. Check for it only if it exists.
if echo "$output" | grep -q "nvidia_dra_requests_total"; then
assert_output --partial "nvidia_dra_requests_total"
fi
}


Expand Down
Loading