Skip to content

Add more gpu examples#327

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
guptaNswati:two-container-one-pod
Apr 5, 2026
Merged

Add more gpu examples#327
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
guptaNswati:two-container-one-pod

Conversation

@guptaNswati
Copy link
Copy Markdown
Contributor

@guptaNswati guptaNswati commented Apr 23, 2025

This is to add some more simple examples of GPU allocation like count, 2 containers 2 gpus.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@guptaNswati guptaNswati requested a review from klueska April 23, 2025 21:36
@guptaNswati
Copy link
Copy Markdown
Contributor Author

guptaNswati commented Apr 23, 2025

These are also relevant for my testing of the gpu-mutating-webhook #326

@guptaNswati guptaNswati requested a review from elezar April 23, 2025 21:38
elezar
elezar reviewed May 7, 2025
View reviewed changes
Comment thread demo/specs/quickstart/gpu-test-count.yaml
elezar
elezar reviewed May 7, 2025
View reviewed changes
Comment thread demo/specs/quickstart/gpu-test-count.yaml Outdated
elezar
elezar reviewed May 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guptaNswati. I have some minor comments.

@guptaNswati
Add more gpu examples
8543545 
Signed-off-by: Swati Gupta <swatig@nvidia.com>
@guptaNswati guptaNswati force-pushed the two-container-one-pod branch from f25794e to 8543545 Compare May 20, 2025 19:51
@guptaNswati
Copy link
Copy Markdown
Contributor Author

guptaNswati commented May 20, 2025

@elezar I updated with the suggestions. thanks

@guptaNswati guptaNswati requested a review from elezar June 2, 2025 22:13
@guptaNswati
Copy link
Copy Markdown
Contributor Author

guptaNswati commented Jun 2, 2025

Ping on this.

@klueska klueska added this to the unscheduled milestone Aug 13, 2025
@guptaNswati guptaNswati self-assigned this Nov 18, 2025
rajatchopra
rajatchopra reviewed Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread demo/specs/quickstart/gpu-test8.yaml
spec:
containers:
- name: ctr0
image: ubuntu:22.04
Copy link
Copy Markdown

@rajatchopra rajatchopra Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking comment: maybe a smaller image can be used here. We just a shell that respects PATH variable and the sleep command.

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Apr 2, 2026

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 2, 2026
@dims
Copy link
Copy Markdown
Member

dims commented Apr 5, 2026

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, guptaNswati, rajatchopra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2026
@k8s-ci-robot k8s-ci-robot merged commit 9333029 into kubernetes-sigs:main Apr 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klueska klueska Awaiting requested review from klueska

@elezar elezar Awaiting requested review from elezar

1 more reviewer

@rajatchopra rajatchopra rajatchopra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dims dims

@guptaNswati guptaNswati

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. examples lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

7 participants

@guptaNswati @k8s-triage-robot @dims @k8s-ci-robot @elezar @rajatchopra @klueska