Fix variable name for daemonSet on computeDomain controller#385
Merged
jgehrcke merged 1 commit intokubernetes-sigs:mainfrom Jun 4, 2025
Merged
Conversation
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the renaming of variables to align with the daemonSet context in the computeDomain controller.
- Updated variable names from "deploymentYaml" to "daemonSetYaml" for improved clarity.
- Refactored the conversion from a deployment object to a daemonSet object, and updated the creation call accordingly.
Comments suppressed due to low confidence (1)
cmd/compute-domain-controller/daemonset.go:192
- The renaming from 'deploymentYaml' to 'daemonSetYaml' improves clarity. Ensure that any associated comments or documentation are updated consistently to reflect this change.
var daemonSetYaml bytes.Buffer
Contributor
|
Let's get this in. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.