Increase startupProbe rate for plugin pods#872
Merged
jgehrcke merged 1 commit intokubernetes-sigs:mainfrom Feb 13, 2026
Merged
Conversation
In many cases, both the GPU as well as the CD plugin pods are ready to serve requests a couple hundred milliseconds after startup. The default for `initialDelaySeconds` is zero. That is, the first startup probe happens pretty much immediately, and is likely to fail. With `periodSeconds: 10`, hence, we typically fail the first startup probe and then detect readiness only ~10 seconds after pod startup. The probe itself is cheap; we can safely increase the probing rate to allow for more snappy readiness detection. The overall timeout duration has to remain ~long, for the reasons laid out in kubernetes-sigs#774. Signed-off-by: Dr. Jan-Philip Gehrcke <jgehrcke@nvidia.com>
Contributor
Author
|
Because we often re-install the Helm chart (and then wait for kubelet plugin readiness), this change has a significant impact on the overall duration of the test suite. Some examples follow: Overall CI check duration
GPU plugin upgrade test:
Helm install + wait (explaining the above's speedups):
|
klueska
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases, both the GPU as well as the CD plugin pods are ready to serve requests a couple hundred milliseconds after startup.
The default for
initialDelaySeconds(for a startup probe) is zero. That is, the first startup probe happens pretty much immediately, and is likely to fail.With
periodSeconds: 10, we then detect readiness only ~10 seconds after pod startup.The probe itself is cheap; we can safely increase the probing rate to allow for more snappy readiness detection.
The overall timeout duration has to remain ~long, for the reasons laid out in #774.
--
Downsides?