Skip to content

bump Masterminds/semver dep to v3.4.0#887

Closed
tariq1890 wants to merge 1 commit intomainfrom
update-semver
Closed

bump Masterminds/semver dep to v3.4.0#887
tariq1890 wants to merge 1 commit intomainfrom
update-semver

Conversation

@tariq1890
Copy link
Copy Markdown
Contributor

@tariq1890 tariq1890 commented Feb 19, 2026

No description provided.

@tariq1890 tariq1890 force-pushed the update-semver branch 2 times, most recently from 9a14df2 to 8a648ab Compare February 19, 2026 16:05
@tariq1890
Copy link
Copy Markdown
Contributor Author

tariq1890 commented Feb 19, 2026

The lint failure is addressed here

@tariq1890 tariq1890 added maintenance/chores issue/pr for maintenance, release work, code cleanup, chores dependencies Issue/PR Pull about a dependency file labels Feb 23, 2026
@tariq1890
bump Masterminds/semver dep to v3.4.0
5678747 
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@tariq1890 tariq1890 requested a review from shivamerla February 23, 2026 17:28
@tariq1890 tariq1890 added this to the v26.4.0 milestone Feb 23, 2026
jgehrcke
jgehrcke reviewed Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jgehrcke jgehrcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a pull request description, motivating this? :) I can imagine there's a specific motivation here; or maybe it's just "because we can"?

@jgehrcke
Copy link
Copy Markdown
Contributor

jgehrcke commented Feb 26, 2026

A comment on:
image

Both CI runs were affected by an infra migration. Let's rebase this branch on current head of main; this will trigger these runs again and this time they should actually execute (and yield important signal).

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Apr 2, 2026

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 2, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2026
@tariq1890
Copy link
Copy Markdown
Contributor Author

tariq1890 commented Apr 3, 2026

closing as this PR should be opened from a fork

@tariq1890 tariq1890 closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klueska klueska Awaiting requested review from klueska

@shivamerla shivamerla Awaiting requested review from shivamerla

1 more reviewer

@jgehrcke jgehrcke jgehrcke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Issue/PR Pull about a dependency file maintenance/chores issue/pr for maintenance, release work, code cleanup, chores needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

v26.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tariq1890 @jgehrcke @k8s-triage-robot @k8s-ci-robot