Skip to content

Adding env var to confirm CDI is enabled #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visheshtanksale merged 2 commits into from
Apr 1, 2026
Merged

Adding env var to confirm CDI is enabled #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df3a86f
Adding env var to confirm CDI is enabled
visheshtanksale Mar 25, 2026
ac173d7
Using existing env var to confirm CDI is enabled
visheshtanksale Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
.cache/
.bash_history
/compute-domain-controller
/compute-domain-daemon
/compute-domain-kubelet-plugin
/gpu-kubelet-plugin
/webhook
.idea
[._]*.sw[a-p]
coverage.out
Expand Down
8 changes: 8 additions & 0 deletions cmd/compute-domain-daemon/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,14 @@ func newApp() *cli.App {

// Run invokes the IMEX daemon and manages its lifecycle.
func run(ctx context.Context, cancel context.CancelFunc, flags *Flags) error {
// Verify that CDI container edits were applied by the container runtime by
// checking for COMPUTE_DOMAIN_UUID, which is always injected as part of the
// CDI edits. If it is missing, CDI is likely disabled and the daemon cannot
// function correctly (e.g. the /imexd mount will be missing).
if flags.computeDomainUUID == "" {
return fmt.Errorf("CDI container edits did not apply -- is CDI enabled in your container runtime?")
}

common.StartDebugSignalHandlers()

// Validate feature gate dependencies
Expand Down
Loading