Skip to content

fix syntax error where "{$var}" results in literal {} wrapped around file name#968

Merged
shivamerla merged 1 commit intokubernetes-sigs:mainfrom
leiyiz:main
Mar 31, 2026
Merged

fix syntax error where "{$var}" results in literal {} wrapped around file name#968
shivamerla merged 1 commit intokubernetes-sigs:mainfrom
leiyiz:main

Conversation

@leiyiz
Copy link
Copy Markdown
Contributor

@leiyiz leiyiz commented Mar 26, 2026

while working on #912, found that scripts/unbind_from_driver.sh has a syntax error where "{}" was added to filename.

This issue likely will cause the acquire_unbind_lock to spin and always fail to acquire unbind lock.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 26, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

…file name

Signed-off-by: Léiyì Zhang <leiyiz@google.com>
Copy link
Copy Markdown

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

@shivamerla
Copy link
Copy Markdown
Contributor

/ok-to-test 13658f5

@leiyiz
Copy link
Copy Markdown
Contributor Author

leiyiz commented Mar 31, 2026

is there a auto bot to merge this? or could someone with merge power merge this

@shivamerla shivamerla merged commit 8ad5c2b into kubernetes-sigs:main Mar 31, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants