Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @gauravkghildiyal @michaelasp |
|
@aojea: GitHub didn't allow me to assign the following users: michaelasp. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @michaelasp |
michaelasp
left a comment
There was a problem hiding this comment.
Looks good to me overall, let's try and get this in to see if it works as expected and iterate from there if it doesn't. Will approve after minor documentation fixes.
|
/lgtm |
The CI jobs expects this launcher https://testgrid.k8s.io/sig-network-dranet#dranet%20(IPv6),%20master%20(dev)%20%5Bnon-serial%5D