Skip to content

Add tamilmani1989 as reviewer#192

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
tamilmani1989:add-reviewer-tamilmani1989
May 6, 2026
Merged

Add tamilmani1989 as reviewer#192
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
tamilmani1989:add-reviewer-tamilmani1989

Conversation

@tamilmani1989
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Adding myself as reviewer. I will continue contributing and help reviewing dranet PRs/design discussions.

Listing my contributions below:

PRs Merged
#21
#98
#101

#156

PRs reviewed
#75
#77
#153
#138

** Issues **
#42
#19

NONE

@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for dranet canceled.

Name Link
🔨 Latest commit dbef5d7
🔍 Latest deploy log https://app.netlify.com/projects/dranet/deploys/69fac8f1bcd28b0008637e53

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @tamilmani1989. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2026
@tamilmani1989
Copy link
Copy Markdown
Contributor Author

@tamilmani1989 tamilmani1989 changed the title Add tamilmani1989 as reviewer in OWNERS Add tamilmani1989 as reviewer May 6, 2026
@aojea
Copy link
Copy Markdown
Contributor

aojea commented May 6, 2026

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2026
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2026
@aojea
Copy link
Copy Markdown
Contributor

aojea commented May 6, 2026

@tamilmani1989 the CI complains about the owners file format

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anson627, aojea, tamilmani1989

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anson627
Copy link
Copy Markdown
Contributor

anson627 commented May 6, 2026

@tamilmani1989 you need become sig member first https://github.com/kubernetes/community/blob/main/community-membership.md#member, I went through the same process and can share more details

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2026
Comment thread OWNERS
reviewers:
- anson627
- mikezappa87
- tamilmani1989
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there some space , end of line or something that makes this invalid?

Copy link
Copy Markdown
Contributor Author

@tamilmani1989 tamilmani1989 May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i missed accepting k8s-sigs invitation. its probably due to that. i retriggered verify owners

@tamilmani1989
Copy link
Copy Markdown
Contributor Author

@tamilmani1989 you need become sig member first https://github.com/kubernetes/community/blob/main/community-membership.md#member, I went through the same process and can share more details

/hold

yes I did.. kubernetes/org#6306. I missed accepting invitation which i did yesterday.

@tamilmani1989
Copy link
Copy Markdown
Contributor Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 6, 2026
@gauravkghildiyal
Copy link
Copy Markdown
Member

Seems like we're good now.
Great to have you on board @tamilmani1989

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2026
@k8s-ci-robot k8s-ci-robot merged commit 0f16046 into kubernetes-sigs:main May 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants