Remove multiple pods sharing one claim in prepareResourceClaim#214
Conversation
✅ Deploy Preview for dranet canceled.
|
|
Hi @ngcxy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5bc6593 to
f1da620
Compare
gauravkghildiyal
left a comment
There was a problem hiding this comment.
Thanks @ngcxy
/ok-to-test
|
/assign |
|
/lgtm |
f1da620 to
f23a2bd
Compare
|
Thanks! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, ngcxy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Previously
prepareResourceClaimimplements the iteration over pods reserved for a single claim. This is a preparation work for the scenario where a single claim could be shared among multiple pods, when they're claiming a shared device. Currently this logic is never used since shared device hasn't been introduced yet.Our finalized design came out that even in shared device scenarios, each pod will get its own distinct ResourceClaim, and the driver handles subinterface creation per claim. Therefore this iteration over multiple pods becomes redundant.
This change removes this logic to simply the preparation logic given this design.
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?