chore: add startup probe to avoid false unhealthy events#222
Open
fmuyassarov wants to merge 1 commit into
Open
chore: add startup probe to avoid false unhealthy events#222fmuyassarov wants to merge 1 commit into
fmuyassarov wants to merge 1 commit into
Conversation
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fmuyassarov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for dranet canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Give the driver enough time to complete plugin registration before throwing unhealthy events, which may give wrong signal. While introducing events in #221, I noticed probe failure events on the driver Pod and I was a bit confused for a while until I realized that readinessProbe was faster than DRANET waiting timeout for the kubelet to complete plugin registration (30 sec). Thus, adding startup timeout should avoid getting false positives even if the registration timeout takes longer but no more than 30 sec which is set here.
I've given in total 60s for the startup probe (2 times 30s timeout set for the kubelet plugin registration) and those extra seconds basically to cover image pulling and other stuff that are not directly about the driver itself.
before
after
Which issue(s) this PR is related to:
"N/A".
Special notes for your reviewer:
Does this PR introduce a user-facing change?