Skip to content

Conversation

@stmcginnis
Copy link
Contributor

@stmcginnis stmcginnis commented Jan 22, 2026

WithCredentialsFile has been deprecated for security reasons. This updates the code to use the recommended WithAuthCredentialsFile introduced in the v0.258.0 release with the corresponding credential type that was used internally to the deprecated method.

Needed before we can take the update proposed in #38

Closes: #43

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2026
@gauravkghildiyal
Copy link
Member

Thanks @stmcginnis

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, stmcginnis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
@stmcginnis
Copy link
Contributor Author

Ah, I misread. The existing library version has WithAuthCredentials but not WithAuthCredentialsFile. It isn't added until v0.258.0. So we need this along with the dependency update for it to pass. I don't have the ability to push to that dependabot branch, but if someone that does wants to cherry-pick this over...

The other option is to move to that version first to be able to move off the deprecated function, then after that update again to the latest one proposed by dependabot. I actually have the ability to do that, so I'll update this PR to make the interim hop for now. Feel free to bypass to go directly to the newer version.

@gauravkghildiyal
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2026
WithCredentialsFile has been deprecated for security reasons. This
updates the code to use the recommended WithAuthCredentialsFile
introduced in the v0.258.0 with the corresponding credential type that
was used internally to the deprecated method.

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
@stmcginnis stmcginnis force-pushed the deprecated-withcredfile branch from 2217978 to 6c6aa1a Compare January 22, 2026 22:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2026
@aojea
Copy link
Contributor

aojea commented Jan 23, 2026

test are passing, should be ok now to merge?

@gauravkghildiyal
Copy link
Member

Yep can merge now.

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 24, 2026
@k8s-ci-robot k8s-ci-robot merged commit 30a5075 into kubernetes-sigs:main Jan 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

this needs to fix a linter issue since it seems a function is deprecated

4 participants