-
Notifications
You must be signed in to change notification settings - Fork 16
Handle GKE client WithCredentialsFile deprecation #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle GKE client WithCredentialsFile deprecation #48
Conversation
|
Thanks @stmcginnis /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ah, I misread. The existing library version has The other option is to move to that version first to be able to move off the deprecated function, then after that update again to the latest one proposed by dependabot. I actually have the ability to do that, so I'll update this PR to make the interim hop for now. Feel free to bypass to go directly to the newer version. |
|
/hold |
WithCredentialsFile has been deprecated for security reasons. This updates the code to use the recommended WithAuthCredentialsFile introduced in the v0.258.0 with the corresponding credential type that was used internally to the deprecated method. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
2217978 to
6c6aa1a
Compare
|
test are passing, should be ok now to merge? |
|
Yep can merge now. /lgtm |
WithCredentialsFile has been deprecated for security reasons. This updates the code to use the recommended WithAuthCredentialsFile introduced in the v0.258.0 release with the corresponding credential type that was used internally to the deprecated method.
Needed before we can take the update proposed in #38
Closes: #43