Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(banner): standardize user agent and output #5154

Merged
merged 13 commits into from
Mar 24, 2025
Merged

feat(banner): standardize user agent and output #5154

merged 13 commits into from
Mar 24, 2025

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Mar 9, 2025 •
edited
Loading

Description

No issue

On startup

Screenshot 2025-03-09 at 11 28 33

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2025
@ivankatliarchuk ivankatliarchuk marked this pull request as draft March 9, 2025 11:20
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2025
@ivankatliarchuk
chore(banner): add banner
3c2e4f3 
Signed-off-by: ivan katliarchuk <[email protected]>
@ivankatliarchuk
chore(banner): add banner
6f950d2 
Signed-off-by: ivan katliarchuk <[email protected]>
@ivankatliarchuk ivankatliarchuk changed the title WIP feat(banner): standartise user agent and output banner feat(banner): standartise user agent and output banner Mar 9, 2025
@ivankatliarchuk ivankatliarchuk marked this pull request as ready for review March 9, 2025 11:31
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2025
@ivankatliarchuk
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 9, 2025
@ivankatliarchuk
chore(banner): add banner
a45ddb5 
Signed-off-by: ivan katliarchuk <[email protected]>
@ivankatliarchuk
Copy link
Contributor Author

@mloiseleur do you think we could fit this change into next release or already too many things there?

@mloiseleur
Copy link
Collaborator

/lgtm

@mloiseleur do you think we could fit this change into next release or already too many things there?

Yes, there are already many in current release.
=> I think we should get it for next minor version.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2025
@mloiseleur
Copy link
Collaborator

/retitle feat(banner): standardize user agent and output

@k8s-ci-robot k8s-ci-robot changed the title feat(banner): standartise user agent and output banner feat(banner): standardize user agent and output Mar 15, 2025
@mloiseleur
Copy link
Collaborator

mloiseleur commented Mar 15, 2025 •
edited
Loading

@onedr0p @buroa Do you think one of you can review this PR ? We need a second review before merge.

buroa
buroa approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@buroa buroa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

@buroa: changing LGTM is restricted to collaborators

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 17, 2025
@mloiseleur
Copy link
Collaborator

Thanks @buroa 👍
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: buroa, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit f6d49dd into kubernetes-sigs:master Mar 24, 2025
13 checks passed
@ivankatliarchuk ivankatliarchuk deleted the chore-user-agen-and-banner branch March 24, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buroa buroa buroa approved these changes

@szuecs szuecs Awaiting requested review from szuecs

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

Assignees

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivankatliarchuk @mloiseleur @k8s-ci-robot @buroa