Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pihole): support v5 and v6 #5203

Closed
wants to merge 36 commits into from

Conversation

tJouve
Copy link

@tJouve tJouve commented Mar 20, 2025

Description

Implementation for the PiHole provider to be compatible qith the PiHole V6 version.
This version change the API of PiHole. This PR implement the new one.

Fixes #5113

Checklist

  • Unit tests updated
  • End user documentation updated

Copy link

linux-foundation-easycla bot commented Mar 20, 2025

CLA Missing ID CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @tJouve. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 20, 2025
@ivankatliarchuk
Copy link
Contributor

/ok-to-test
/label tide/merge-method-squash

Could you do rebase from master and sign CLA?

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2025
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some time to review/dive-in into an actual code

Is there is any tutorial how to configure pi-hole with minikube or kind?

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2025
@tJouve tJouve mentioned this pull request Mar 20, 2025
8 tasks
@tJouve
Copy link
Author

tJouve commented Mar 20, 2025

need some time to review/dive-in into an actual code

Is there is any tutorial how to configure pi-hole with minikube or kind?

You can use this manifest, external dns config example is available here :

apiVersion: v1
kind: Service
metadata:
  name: pihole-service
spec:
  selector:
    app.kubernetes.io/name: pihole
  ports:
    - protocol: TCP
      port: 53
      name: pihole-dns-tcp
    - protocol: UDP
      port: 53
      name: pihole-dns-udp
    - protocol: TCP
      port: 80
      name: http
---
apiVersion: v1
kind: Pod
metadata:
  name: pihole
  labels:
    app.kubernetes.io/name: pihole
spec:
  containers:
    - name: pihole
      image: pihole/pihole:2025.02.4
      env:
        - name: FTLCONF_dns_upstreams
          value: "8.8.8.8"
        - name: FTLCONF_webserver_api_password
          value: "piholeadmin"
        - name: FTLCONF_dns_listeningMode
          value: 'all'
      ports:
        - containerPort: 80
          name: http
          protocol: TCP
        - containerPort: 53
          name: pihole-dns-tcp
          protocol: TCP
        - containerPort: 53
          name: pihole-dns-udp
          protocol: UDP
      volumeMounts:
        - mountPath: /etc/pihole
          name: pihole
        - mountPath: /etc/dnsmasq.d
          name: dnsmasq
  volumes:
  - name: pihole
    emptyDir:
      sizeLimit: 50Mi
  - name: dnsmasq
    emptyDir:
      sizeLimit: 50Mi

@tJouve
Copy link
Author

tJouve commented Mar 21, 2025

/retest

@RonaldPhilipsen
Copy link

Let me know if you need anyone to test this, I'd love to get this working in my cluster

@ivankatliarchuk
Copy link
Contributor

/retitle fix(pihole): support v5 and v6

@k8s-ci-robot k8s-ci-robot changed the title Feat/piholev6 fix(pihole): support v5 and v6 Mar 22, 2025
@ivankatliarchuk
Copy link
Contributor

need to sign CLA so we could do a review

@tJouve tJouve mentioned this pull request Mar 26, 2025
2 tasks
@tJouve
Copy link
Author

tJouve commented Mar 26, 2025

No news from the other contributor regarding CLA I create an other PR from a squash branch.

See #5226

@tJouve tJouve closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new pi-hole server v6 results in 404 error
4 participants