-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pihole): support v5 and v6 #5203
Conversation
Fixing tests and a small logic error
Add PiholeApiVersion param
Update Documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @tJouve. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test Could you do rebase from master and sign CLA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need some time to review/dive-in into an actual code
Is there is any tutorial how to configure pi-hole with minikube or kind?
# Conflicts: # pkg/apis/externaldns/types.go
You can use this manifest, external dns config example is available here : apiVersion: v1
kind: Service
metadata:
name: pihole-service
spec:
selector:
app.kubernetes.io/name: pihole
ports:
- protocol: TCP
port: 53
name: pihole-dns-tcp
- protocol: UDP
port: 53
name: pihole-dns-udp
- protocol: TCP
port: 80
name: http
---
apiVersion: v1
kind: Pod
metadata:
name: pihole
labels:
app.kubernetes.io/name: pihole
spec:
containers:
- name: pihole
image: pihole/pihole:2025.02.4
env:
- name: FTLCONF_dns_upstreams
value: "8.8.8.8"
- name: FTLCONF_webserver_api_password
value: "piholeadmin"
- name: FTLCONF_dns_listeningMode
value: 'all'
ports:
- containerPort: 80
name: http
protocol: TCP
- containerPort: 53
name: pihole-dns-tcp
protocol: TCP
- containerPort: 53
name: pihole-dns-udp
protocol: UDP
volumeMounts:
- mountPath: /etc/pihole
name: pihole
- mountPath: /etc/dnsmasq.d
name: dnsmasq
volumes:
- name: pihole
emptyDir:
sizeLimit: 50Mi
- name: dnsmasq
emptyDir:
sizeLimit: 50Mi |
/retest |
Let me know if you need anyone to test this, I'd love to get this working in my cluster |
/retitle fix(pihole): support v5 and v6 |
need to sign CLA so we could do a review |
No news from the other contributor regarding CLA I create an other PR from a squash branch. See #5226 |
Description
Implementation for the PiHole provider to be compatible qith the PiHole V6 version.
This version change the API of PiHole. This PR implement the new one.
Fixes #5113
Checklist