Skip to content

chore(code-quality): added lint checks #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Apr 23, 2025

Description

  • added few more lint check
  • now changes to actual logic

follow-up; I'll add more linters

Reasons for changes
Screenshot 2025-04-23 at 07 07 41

Screenshot 2025-04-23 at 07 25 37
Screenshot 2025-04-23 at 07 26 20
Screenshot 2025-04-23 at 07 32 04
Screenshot 2025-04-23 at 08 09 23
Screenshot 2025-04-23 at 08 11 11

Screenshot 2025-04-23 at 07 12 40

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: ivan katliarchuk <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 23, 2025
@ivankatliarchuk ivankatliarchuk changed the title chore(refactore): added lint checks chore(code-quality): added lint checks Apr 23, 2025
@mloiseleur
Copy link
Collaborator

/lgtm
It's only rename / linter fixes, so I do not think it needs a second review for this one.
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit bc96176 into kubernetes-sigs:master Apr 23, 2025
14 checks passed
@ivankatliarchuk ivankatliarchuk deleted the chore-refactoring-v0 branch April 23, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants