Skip to content

chore(code-quality): providers linter warnings fixes #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(code-quality): providers linter warnings fixes #5320

wants to merge 1 commit into from

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Apr 23, 2025 •
edited
Loading

Description

Slicing pull request #5312

target is to make sure pull requst 5312 only contain defaultTTL changes

Checklist

  • Unit tests updated
  • End user documentation updated

Linter warnings

Screenshot 2025-04-23 at 21 32 26
Screenshot 2025-04-23 at 21 32 30
Screenshot 2025-04-23 at 21 35 17
Screenshot 2025-04-23 at 21 35 41
Screenshot 2025-04-23 at 21 44 51
Screenshot 2025-04-23 at 21 48 17

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mloiseleur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2025
@ivankatliarchuk ivankatliarchuk changed the title chore(code-quality): linter warnings fixes chore(code-quality): providers linter warnings fixes Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@szuecs szuecs Awaiting requested review from szuecs

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivankatliarchuk @k8s-ci-robot