chore(cloudflare): migrate customhostname to v5 #5891

AndrewCharlesHay · 2025-10-06T21:49:49Z

What does it do ?

Migrate customhostname to v5

Motivation

Closes #5540

More

Yes, this PR title follows Conventional Commits
Yes, I added unit tests
Yes, I updated end user documentation accordingly

k8s-ci-robot · 2025-10-06T21:49:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coveralls · 2025-10-06T21:57:47Z

Pull Request Test Coverage Report for Build 19845553576

Details

0 of 0 changed or added relevant lines in 0 files are covered.
99 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 78.501%

Files with Coverage Reduction	New Missed Lines	%
cloudflare/cloudflare_regional.go	15	92.06%
cloudflare/cloudflare.go	84	87.74%

Totals
Change from base Build 19831487154:	-0.2%
Covered Lines:	15942
Relevant Lines:	20308

💛 - Coveralls

docs/tutorials/cloudflare.md

mloiseleur · 2025-10-09T06:01:56Z

@vflaux @mrozentsvayg Any comment on this PR ? Do you think you can review it ?

go.mod

provider/cloudflare/cloudflare.go

vflaux · 2025-10-09T15:39:35Z

provider/cloudflare/cloudflare.go

+	if strings.Contains(errStr, "exceeded available rate limit retries") ||
+		strings.Contains(errStr, "rate limit") ||
+		strings.Contains(errStr, "429") {


I think we should handle this according to the doc here: https://github.com/cloudflare/cloudflare-go?tab=readme-ov-file#errors

var apierr *cloudflare.Error if errors.As(err, &apierr) { if apierr.StatusCode == http.StatusTooManyRequests { } }

This was implemented

so why do we have this code here?

Rate limit errors are not returned as ErrorTypeRateLimit cloudflare/cloudflare-go#4155 talks about the v0 version of the library which we don't use after merging your PR.

the first string.Contains is not needed if you have the second one.

Sorry forgot to commit it. It's gone now

provider/cloudflare/cloudflare.go

k8s-ci-robot · 2025-10-09T15:47:49Z

@vflaux: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

AndrewCharlesHay · 2025-10-10T17:11:58Z

How did broken tests get merged in?

vflaux · 2025-10-13T11:06:27Z

How did broken tests get merged in?

This should be fixed, see #5896.

AndrewCharlesHay · 2025-10-13T15:01:36Z

/retest

AndrewCharlesHay · 2025-10-13T19:55:19Z

@vflaux everything look good now?

vflaux

I've not review all the new tests yet.
Looks like IA generated, some clearly improve test coverage, others seems less relevant. 😄

provider/cloudflare/cloudflare.go

provider/cloudflare/cloudflare_test.go

provider/cloudflare/cloudflare.go

go.mod

AndrewCharlesHay · 2025-10-24T18:44:37Z

The tests just fail because of rate limits to coveralls

provider/cloudflare/cloudflare.go

szuecs · 2025-10-31T09:01:58Z

Did you @AndrewCharlesHay address comments by @vflaux ?

Cleaning up things that are not useful is always great for maintaining the software.

AndrewCharlesHay · 2025-11-04T23:03:46Z

@szuecs yep all updated

mloiseleur · 2025-11-08T11:46:15Z

@AndrewCharlesHay Would you please rebase ?

mloiseleur · 2025-11-11T15:30:38Z

@vflaux @szuecs Anything left on your side ?

mloiseleur

@vflaux Anything left on your side ?

ivankatliarchuk · 2025-12-09T07:57:20Z

Was this code tested against cloudflare? Change does look riskie without testing.

mrozentsvayg · 2025-12-10T23:22:45Z

provider/cloudflare/cloudflare.go

-	return z.serviceV0.CreateCustomHostname(ctx, zoneID, ch)
+func (z zoneService) CreateCustomHostname(ctx context.Context, zoneID string, ch CustomHostname) error {
+	params := buildCustomHostnameNewParams(zoneID, ch)
+	_, err := z.service.CustomHostnames.New(ctx, params)


this creates a custom hostname with empty origin server, and then breaks infinitely attempting and failing to recreate the duplicate;

api v5 makes setting the custom origin server so much less obvious for the reason I don't understand;
but this works as expected in my testing:

- _, err := z.service.CustomHostnames.New(ctx, params) + _, err := z.service.CustomHostnames.New(ctx, params, + option.WithJSONSet("custom_origin_server", ch.CustomOriginServer))

@mrozentsvayg Thank you for the suggestion! I’ve updated the implementation to explicitly set custom_origin_server using option.WithJSONSet as you recommended. This resolves the issue with empty origin servers and infinite retries. The change is now pushed, and all tests pass.

k8s-ci-robot · 2025-12-10T23:23:54Z

@mrozentsvayg: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-12-10T23:24:03Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

* build: tool remove vacuum in order to get rid of BUSL-1.1 license of a dependency in go.mod/go.tool.mod Signed-off-by: Sandor Szuecs <[email protected]> * rm vacuum Signed-off-by: Sandor Szuecs <[email protected]> * remove also from CI Signed-off-by: Sandor Szuecs <[email protected]> --------- Signed-off-by: Sandor Szuecs <[email protected]>

…s#5958) Signed-off-by: Michel Loiseleur <[email protected]>

Bumps the dev-dependencies group with 1 update: [github.com/digitalocean/godo](https://github.com/digitalocean/godo). Updates `github.com/digitalocean/godo` from 1.168.0 to 1.169.0 - [Release notes](https://github.com/digitalocean/godo/releases) - [Changelog](https://github.com/digitalocean/godo/blob/main/CHANGELOG.md) - [Commits](digitalocean/godo@v1.168.0...v1.169.0) --- updated-dependencies: - dependency-name: github.com/digitalocean/godo dependency-version: 1.169.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps the dev-dependencies group with 1 update: [renovatebot/github-action](https://github.com/renovatebot/github-action). Updates `renovatebot/github-action` from 44.0.1 to 44.0.2 - [Release notes](https://github.com/renovatebot/github-action/releases) - [Changelog](https://github.com/renovatebot/github-action/blob/main/CHANGELOG.md) - [Commits](renovatebot/github-action@v44.0.1...v44.0.2) --- updated-dependencies: - dependency-name: renovatebot/github-action dependency-version: 44.0.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…s#5909)

* end to end testing with local provider implementation Signed-off-by: Raffaele Di Fazio <[email protected]> * Update .github/workflows/end-to-end-tests.yml Co-authored-by: Michel Loiseleur <[email protected]> * Update e2e/deployment.yaml Co-authored-by: Michel Loiseleur <[email protected]> * move e2e to coredns Signed-off-by: Raffaele Di Fazio <[email protected]> * newlines Signed-off-by: Raffaele Di Fazio <[email protected]> * Update scripts/e2e-test.sh Co-authored-by: Michel Loiseleur <[email protected]> * drop all comments Signed-off-by: Raffaele Di Fazio <[email protected]> * Update .github/workflows/end-to-end-tests.yml Co-authored-by: Michel Loiseleur <[email protected]> --------- Signed-off-by: Raffaele Di Fazio <[email protected]> Co-authored-by: Michel Loiseleur <[email protected]>

…10 updates (kubernetes-sigs#5970) Bumps the dev-dependencies group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.39.6` | `1.40.0` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.31.20` | `1.32.0` | | [github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue](https://github.com/aws/aws-sdk-go-v2) | `1.20.23` | `1.20.25` | | [github.com/aws/aws-sdk-go-v2/service/route53](https://github.com/aws/aws-sdk-go-v2) | `1.59.5` | `1.60.1` | | [github.com/aws/aws-sdk-go-v2/service/servicediscovery](https://github.com/aws/aws-sdk-go-v2) | `1.39.16` | `1.39.17` | | [github.com/oracle/oci-go-sdk/v65](https://github.com/oracle/oci-go-sdk) | `65.104.1` | `65.105.0` | | [github.com/prometheus/common](https://github.com/prometheus/common) | `0.67.2` | `0.67.3` | Updates `github.com/aws/aws-sdk-go-v2` from 1.39.6 to 1.40.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@v1.39.6...v1.40.0) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.31.20 to 1.32.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@config/v1.31.20...v1.32.0) Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.18.24 to 1.19.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.19.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@config/v1.18.24...v1.19.0) Updates `github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue` from 1.20.23 to 1.20.25 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@feature/dynamodb/attributevalue/v1.20.23...feature/dynamodb/attributevalue/v1.20.25) Updates `github.com/aws/aws-sdk-go-v2/service/dynamodb` from 1.52.6 to 1.53.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/ssm/v1.52.6...service/s3/v1.53.1) Updates `github.com/aws/aws-sdk-go-v2/service/route53` from 1.59.5 to 1.60.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/iot/v1.59.5...service/s3/v1.60.1) Updates `github.com/aws/aws-sdk-go-v2/service/servicediscovery` from 1.39.16 to 1.39.17 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/personalize/v1.39.16...service/servicediscovery/v1.39.17) Updates `github.com/aws/aws-sdk-go-v2/service/sts` from 1.40.2 to 1.41.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.40.2...service/kms/v1.41.1) Updates `github.com/oracle/oci-go-sdk/v65` from 65.104.1 to 65.105.0 - [Release notes](https://github.com/oracle/oci-go-sdk/releases) - [Changelog](https://github.com/oracle/oci-go-sdk/blob/master/CHANGELOG.md) - [Commits](oracle/oci-go-sdk@v65.104.1...v65.105.0) Updates `github.com/prometheus/common` from 0.67.2 to 0.67.3 - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/CHANGELOG.md) - [Commits](prometheus/common@v0.67.2...v0.67.3) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2 dependency-version: 1.40.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-version: 1.32.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/credentials dependency-version: 1.19.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue dependency-version: 1.20.25 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/dynamodb dependency-version: 1.53.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/route53 dependency-version: 1.60.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/servicediscovery dependency-version: 1.39.17 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/sts dependency-version: 1.41.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/oracle/oci-go-sdk/v65 dependency-version: 65.105.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/prometheus/common dependency-version: 0.67.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…es-sigs#5969) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.44.0 to 0.45.0. - [Commits](golang/crypto@v0.44.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ubernetes-sigs#5534) According to RFC2782 [1], SRV records are to be fully-qualified, ending with a final dot. Most providers are liberal, but e.g. OpenStack Designate expects targets to end with a dot ([2]) [1] https://datatracker.ietf.org/doc/html/rfc2782 [2] https://github.com/openstack/designate/blob/a891d81974a4c3aa56a143252b26df9dcbd5fba5/designate/objects/fields.py#L235-L236 Signed-off-by: Christian Rohmann <[email protected]>

Add alternative UniFi webhook provider implementation. Signed-off-by: Aleksei Sviridkin <[email protected]> Co-authored-by: Claude <[email protected]>

…9 updates (kubernetes-sigs#5976) Bumps the dev-dependencies group with 6 updates in the / directory: | Package | From | To | | --- | --- | --- | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.32.0` | `1.32.2` | | [github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue](https://github.com/aws/aws-sdk-go-v2) | `1.20.25` | `1.20.26` | | [github.com/aws/aws-sdk-go-v2/service/route53](https://github.com/aws/aws-sdk-go-v2) | `1.60.1` | `1.61.0` | | [github.com/aws/aws-sdk-go-v2/service/servicediscovery](https://github.com/aws/aws-sdk-go-v2) | `1.39.17` | `1.39.18` | | [github.com/prometheus/common](https://github.com/prometheus/common) | `0.67.3` | `0.67.4` | | gopkg.in/ns1/ns1-go.v2 | `2.15.1` | `2.15.2` | Updates `github.com/aws/aws-sdk-go-v2/config` from 1.32.0 to 1.32.2 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@v1.32.0...v1.32.2) Updates `github.com/aws/aws-sdk-go-v2/credentials` from 1.19.0 to 1.19.2 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@v1.19.0...service/m2/v1.19.2) Updates `github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue` from 1.20.25 to 1.20.26 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@feature/dynamodb/attributevalue/v1.20.25...feature/dynamodb/attributevalue/v1.20.26) Updates `github.com/aws/aws-sdk-go-v2/service/dynamodb` from 1.53.1 to 1.53.2 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.53.1...service/s3/v1.53.2) Updates `github.com/aws/aws-sdk-go-v2/service/route53` from 1.60.1 to 1.61.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.60.1...service/s3/v1.61.0) Updates `github.com/aws/aws-sdk-go-v2/service/servicediscovery` from 1.39.17 to 1.39.18 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/servicediscovery/v1.39.17...service/servicediscovery/v1.39.18) Updates `github.com/aws/aws-sdk-go-v2/service/sts` from 1.41.1 to 1.41.2 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@service/kms/v1.41.1...service/ivs/v1.41.2) Updates `github.com/prometheus/common` from 0.67.3 to 0.67.4 - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/CHANGELOG.md) - [Commits](prometheus/common@v0.67.3...v0.67.4) Updates `gopkg.in/ns1/ns1-go.v2` from 2.15.1 to 2.15.2 --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-version: 1.32.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/credentials dependency-version: 1.19.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/feature/dynamodb/attributevalue dependency-version: 1.20.26 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/dynamodb dependency-version: 1.53.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/route53 dependency-version: 1.61.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/servicediscovery dependency-version: 1.39.18 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/aws/aws-sdk-go-v2/service/sts dependency-version: 1.41.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: github.com/prometheus/common dependency-version: 0.67.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies - dependency-name: gopkg.in/ns1/ns1-go.v2 dependency-version: 2.15.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…oup (kubernetes-sigs#5985) Bumps the dev-dependencies group with 1 update: [github.com/goccy/go-yaml](https://github.com/goccy/go-yaml). Updates `github.com/goccy/go-yaml` from 1.18.0 to 1.19.0 - [Release notes](https://github.com/goccy/go-yaml/releases) - [Changelog](https://github.com/goccy/go-yaml/blob/master/CHANGELOG.md) - [Commits](goccy/go-yaml@v1.18.0...v1.19.0) --- updated-dependencies: - dependency-name: github.com/goccy/go-yaml dependency-version: 1.19.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

… comments - Add comprehensive test coverage for buildCustomHostnameNewParams function - Improve comment explaining why string-based rate limit detection is needed with v5 SDK (SDK's retry logic can wrap errors hiding structured types) - Addresses reviewer feedback about test coverage and error handling rationale

k8s-ci-robot · 2025-12-13T21:31:01Z

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

0309f8a chore(deps): bump github.com/digitalocean/godo (chore(deps): bump github.com/digitalocean/godo from 1.168.0 to 1.169.0 in the dev-dependencies group #5956)
452265e chore(deps): bump renovatebot/github-action (chore(deps): bump renovatebot/github-action from 44.0.1 to 44.0.2 in the dev-dependencies group #5950)
fed0858 chore(deps): bump the dev-dependencies group across 1 directory with 10 updates (chore(deps): bump the dev-dependencies group across 1 directory with 10 updates #5970)
8bab0ca chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0 (chore(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0 #5969)
aab65cc chore(deps): bump the dev-dependencies group across 1 directory with 9 updates (chore(deps): bump the dev-dependencies group across 1 directory with 9 updates #5976)
71bc535 chore(deps): bump github.com/goccy/go-yaml in the dev-dependencies group (chore(deps): bump github.com/goccy/go-yaml from 1.18.0 to 1.19.0 in the dev-dependencies group #5985)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot · 2025-12-13T21:31:08Z

@AndrewCharlesHay: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-external-dns-licensecheck	`803de1a`	link	true	`/test pull-external-dns-licensecheck`
pull-external-dns-unit-test	`803de1a`	link	true	`/test pull-external-dns-unit-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2025

k8s-ci-robot requested a review from ivankatliarchuk October 6, 2025 21:49

k8s-ci-robot added the provider Issues or PRs related to a provider label Oct 6, 2025

k8s-ci-robot requested a review from szuecs October 6, 2025 21:49

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 6, 2025

k8s-ci-robot added the docs label Oct 7, 2025

mloiseleur reviewed Oct 7, 2025

View reviewed changes

docs/tutorials/cloudflare.md Outdated Show resolved Hide resolved

AndrewCharlesHay changed the title ~~Andrewcharleshay/cloudflare migration v5~~ chore(cloudflare): migrate customhostname to v5 Oct 7, 2025

vflaux suggested changes Oct 9, 2025

View reviewed changes

vflaux mentioned this pull request Oct 14, 2025

REQUEST: New membership for @vflaux kubernetes/org#5925

Closed

11 tasks

vflaux suggested changes Oct 17, 2025

View reviewed changes

k8s-ci-robot assigned vflaux Oct 17, 2025

szuecs reviewed Oct 24, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

szuecs reviewed Oct 31, 2025

View reviewed changes

provider/cloudflare/cloudflare.go Outdated Show resolved Hide resolved

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2025

AndrewCharlesHay force-pushed the andrewcharleshay/cloudflare-migration-v5 branch from e0eb277 to bcad628 Compare November 10, 2025 15:43

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2025

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025

mloiseleur reviewed Dec 7, 2025

View reviewed changes

mrozentsvayg suggested changes Dec 10, 2025

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2025

szuecs and others added 15 commits December 12, 2025 22:38

chore(ci): fix releaser script (kubernetes-sigs#5953)

8bafc69

chore(release): updates kustomize & docs with v0.20.0 (kubernetes-sig…

0b653f8

…s#5958) Signed-off-by: Michel Loiseleur <[email protected]>

feat: add support for ingress backed GlooEdge Gateway (kubernetes-sig…

94cfcf9

…s#5909)

docs: add UniFi webhook provider to README (kubernetes-sigs#5967)

2c7ca01

Add alternative UniFi webhook provider implementation. Signed-off-by: Aleksei Sviridkin <[email protected]> Co-authored-by: Claude <[email protected]>

fix: rebase

803de1a

AndrewCharlesHay force-pushed the andrewcharleshay/cloudflare-migration-v5 branch from cfefead to 803de1a Compare December 13, 2025 21:30

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 13, 2025

k8s-ci-robot added chart kustomize Issues or PRs related to kustomize installation scripts Issues or PRs related to internal scripts source labels Dec 13, 2025

chore(cloudflare): migrate customhostname to v5 #5891

Are you sure you want to change the base?

chore(cloudflare): migrate customhostname to v5 #5891

Uh oh!

Conversation

AndrewCharlesHay commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does it do ?

Motivation

More

Uh oh!

k8s-ci-robot commented Oct 6, 2025

Uh oh!

coveralls commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 19845553576

Details

💛 - Coveralls

Uh oh!

Uh oh!

mloiseleur commented Oct 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vflaux Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

AndrewCharlesHay Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

szuecs Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewCharlesHay Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 9, 2025

Uh oh!

AndrewCharlesHay commented Oct 10, 2025

Uh oh!

vflaux commented Oct 13, 2025

Uh oh!

AndrewCharlesHay commented Oct 13, 2025

Uh oh!

AndrewCharlesHay commented Oct 13, 2025

Uh oh!

vflaux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewCharlesHay commented Oct 24, 2025

Uh oh!

Uh oh!

szuecs commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewCharlesHay commented Nov 4, 2025

Uh oh!

mloiseleur commented Nov 8, 2025

Uh oh!

mloiseleur commented Nov 11, 2025

Uh oh!

mloiseleur left a comment

Choose a reason for hiding this comment

Uh oh!

ivankatliarchuk commented Dec 9, 2025

Uh oh!

mrozentsvayg Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AndrewCharlesHay commented Oct 6, 2025 •

edited

Loading

coveralls commented Oct 6, 2025 •

edited

Loading

szuecs Oct 24, 2025 •

edited

Loading

szuecs commented Oct 31, 2025 •

edited

Loading

mrozentsvayg Dec 10, 2025 •

edited

Loading