fix(zonefinder): transform zone name to unicode as well

[rbeuque74]

What does it do ?

This change fix a different of behaviour inside provider/zone_finder.
Record name are converted to unicode, while zone name were not converted as unicode when inserted, leading to inconsistencies.

Motivation

Fixes #5914

With #5147, external-dns now handle IDNA zone name, and zone_finder is handling them as unicode.
But, if a provider pushes a zone name punnyencoded, and not using unicode, the find function is not handing it correctly.

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[k8s-ci-robot]

Hi @rbeuque74. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

/ok-to-test

[coveralls]

Pull Request Test Coverage Report for Build 19746205961

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 42 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.04%) to 78.63%

---

Files with Coverage Reduction	New Missed Lines	%
zonefinder.go	3	90.0%
ovh/ovh.go	39	91.75%

Totals
Change from base Build 19598374265:	-0.04%
Covered Lines:	15969
Relevant Lines:	20309

---

💛 - Coveralls

[mloiseleur]

@feluxe Do you think you can test this PR and confirm if it fixes your issue ?

[mloiseleur]

/lgtm

[ivankatliarchuk]

Suggested change

	return nil, provider.NewSoftError(fmt.Errorf("record %q have not found matching DNS zone in OVH provider", endpt.DNSName))
	return nil, provider.NewSoftErrorf("record %q have not found matching DNS zone in OVH provider", endpt.DNSName)

[ivankatliarchuk]

same NewSoftErrorf

[ivankatliarchuk]

why not to first

if DNSName == zoneName {
		return ""
	}

and only then execute idna normalisation?

I have tried

func convertDNSNameIntoSubDomain(DNSName string, zoneName string) string { // nolint: gocritic // captLocal
	if DNSName == zoneName {
		return ""
	}

	if name, err := idna.Profile.ToUnicode(DNSName); err == nil {
		DNSName = name
	}
	if name, err := idna.Profile.ToUnicode(zoneName); err == nil {
		zoneName = name
	}

	return strings.TrimSuffix(DNSName, "."+zoneName)
}

All tests still green, either required a test that will fail or we could do the fastest check first.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mloiseleur. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[szuecs]

same NewSoftErrorf

[szuecs]

same NewSoftErrorf