feat(godaddy): add option to disable api key/secret validation

[alexstojda]

What does it do ?

The previous change I made did not fix the rate limiting issues. This will provide an option to just skip the validation all together.

Flag will default to false, so that existing installations will still validate the API Key/Secret

Motivation

During startup, the client calls the endpoint https://api.godaddy.com/v1/domains?statuses=ACTIVE,PENDING_DNS_ACTIVE1 to test and validate that the credentials are working.

#4866 sought to fix an underlying issue by ignoring QUOTA_EXCEEDED errors on the initial validation call, since theory was that there was a per-endpoint limit. However, after running the fix for the last year, we still hit some other rate limit fairly often.

My understanding now is that there is still some global & account-level rate limit whose threshold is often hit because of the initial "validation" request.

Considering there are very few people reporting that they are running into this issue (I hypothesize this is because not many people are using the godaddy provider at a similar scale), I decided that it would be a more effective approach to provide the option to disable that validation on startup altogether.

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

Relates to #4866

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @alexstojda. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

Can you detail your motivation?

🤔 How avoiding validation on the API key may fix the rate limit issue with the GoDaddy API?

[alexstojda]

@mloiseleur I've updated the PR description to elaborate :)

[mloiseleur]

@alexstojda I'm probably missing something here 🤔.

Are you saying that you hit the rate/limit because of

a. a single startup request?
b. a request that is launched on every reconcile loop?

[alexstojda]

@alexstojda I'm probably missing something here 🤔.

Are you saying that you hit the rate/limit because of

a. a single startup request? b. a request that is launched on every reconcile loop?

My current theory is that it is the single startup request, because there is some undocumented monthly rate limits at the account level (and we use the same GoDaddy account across multiple environments).

There is of course no documentation to support this, just what we've seen and what I documented in my testing previously in #4866