chore(source)!: remove cloudfoundry support

[ivankatliarchuk]

What does it do ?

Remove cloudfoundry support

It was added in 2018 #955

No documentation, no updates since 2018. I was using Cloudfoundry years back. Not sure what exactly this code should support. Basically cloudfoundry does not require external-dns, and is a different platform.

Most recent cloudfoundry is very much integrated with Kubernetes https://www.cloudfoundry.org/technology/korifi/, and it does support ingress, service and etc, so does not require anything specific.

Motivation

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[coveralls]

Pull Request Test Coverage Report for Build 20764473363

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 115 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.08%) to 78.898%

---

Files with Coverage Reduction	New Missed Lines	%
apis/externaldns/types.go	1	99.62%
store.go	114	43.01%

Totals
Change from base Build 20762676915:	0.08%
Covered Lines:	15894
Relevant Lines:	20145

---

💛 - Coveralls

[mloiseleur]

🤔 Shouldn't we remove this go-cfclient then?

[ivankatliarchuk]

done

[mloiseleur]

cloudfoundry should then also be removed in flags and docs, or did I miss something?

[ivankatliarchuk]

Correct. Removed

[vflaux]

There is still some refs to cloudfoundry:

• external-dns/pkg/apis/externaldns/types_test.go

  Lines 785 to 795 in d5c2cde

  	func TestParseFlagsCloudFoundry(t *testing.T) {
  	t.Parallel()
  	cfg := parseCfg(t,
  	"--cf-api-endpoint=https://api.cf.example",
  	"--cf-username=user1",
  	"--cf-password=p@ss",
  	)
  	assert.Equal(t, "https://api.cf.example", cfg.CFAPIEndpoint)
  	assert.Equal(t, "user1", cfg.CFUsername)
  	assert.Equal(t, "p@ss", cfg.CFPassword)
  	}

• external-dns/source/store.go

  Line 161 in d5c2cde

  // - CloudFoundryClient: CloudFoundry platform client

• external-dns/source/store.go

  Line 290 in d5c2cde

  // - "cloudfoundry": CloudFoundry applications

• external-dns/source/types/types.go

  Line 33 in d5c2cde

  Cloudfoundry Type = "cloudfoundry"

• external-dns/docs/flags.md

  Lines 15 to 17 in d5c2cde

  	| `--cf-api-endpoint=""` | The fully-qualified domain name of the cloud foundry instance you are targeting |
  	| `--cf-username=""` | The username to log into the cloud foundry API |
  	| `--cf-password=""` | The password to log into the cloud foundry API |

• external-dns/pkg/apis/externaldns/types.go

  Lines 506 to 509 in d5c2cde

  	// Flags related to cloud foundry
  	b.StringVar("cf-api-endpoint", "The fully-qualified domain name of the cloud foundry instance you are targeting", defaultConfig.CFAPIEndpoint, &cfg.CFAPIEndpoint)
  	b.StringVar("cf-username", "The username to log into the cloud foundry API", defaultConfig.CFUsername, &cfg.CFUsername)
  	b.StringVar("cf-password", "The password to log into the cloud foundry API", defaultConfig.CFPassword, &cfg.CFPassword)

• external-dns/pkg/apis/externaldns/types.go

  Lines 172 to 174 in d5c2cde

  	CFAPIEndpoint string
  	CFUsername string
  	CFPassword string

• external-dns/source/store.go

  Lines 88 to 90 in d5c2cde

  	CFAPIEndpoint string
  	CFUsername string
  	CFPassword string

[ivankatliarchuk]

Removed as well

[vflaux]

/lgtm

[mloiseleur]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mloiseleur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment